Review main Merged

46232[BUGFIX] Reallow '0' as valid userFunc argument in TypoScript

Gernot Leitgab CR +2 V +2 Normal +218 −3 updated 02/01/16, 12:33

Commit message

With #47301 the parsing of userFunc in TypoScript has changed.
The change prevents '0' as valid argument.

This patch fix the '0' bug but also adds some new unit tests.
The parser method also includes a bug with quoted values which are not the
last argument. this bug is now fixed too.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1

Issues 2

Files 3

Review log 17

  1. Gernot Leitgab uploaded patch set 1 01/25/16, 18:28

  2. Frank Nägler wrote 01/25/16, 18:44

    Patch set 2: Commit message was updated.
  3. Frank Nägler voted on patch set 2 CR +1 V +1 01/25/16, 18:44

  4. Frank Nägler commented on patch set 2 CR -1 01/25/16, 18:48

    on it, will add some unit tests
  5. Frank Nägler commented on patch set 2 V -1 01/25/16, 18:56

    new unit tests fail with current implementation, will push an update
  6. Frank Nägler uploaded patch set 3 01/25/16, 20:05

  7. Frank Nägler commented on patch set 3 CR +1 V +1 01/25/16, 20:08

    ok, while adding the new unit tests, I found another bug in the parser method. This bug is now also fixed. Please test this patch really carefully. I would like to see a review bei Lolli specially for the new unit tests.
  8. Sascha Egerer commented on patch set 3 CR -1 01/26/16, 10:06

    AbstractConditionMatcher.php:344

    We should add a trim() when doing a strict type string comparison as `foo:bar( )` will return `" "` as value
  9. Frank Nägler commented on patch set 3 01/26/16, 10:13

    AbstractConditionMatcher.php:344 Reply

    agree, but my refactoring should also return an empty array. can't test is yet, maybe this could be another new unit test :)
  10. Sascha Egerer commented on patch set 3 01/26/16, 10:20

    I'll push an update.
  11. Sascha Egerer uploaded patch set 4 01/26/16, 10:44

  12. Christian Kuhn commented on patch set 4 01/26/16, 11:44

    will review
  13. Frank Nägler voted on patch set 4 CR +1 V +1 02/01/16, 10:26

  14. Christian Kuhn voted on patch set 4 CR +1 V +1 02/01/16, 12:19

  15. Frank Nägler voted on patch set 4 CR +2 V +2 02/01/16, 12:32

  16. Gerrit merged patch set 4 02/01/16, 12:32

  17. Frank Nägler commented on patch set 5 02/01/16, 12:33

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 0509f9e1fb54f097b28d21661c6d7a7b02bd1c9b