46232[BUGFIX] Reallow '0' as valid userFunc argument in TypoScript
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Christian Kuhn +1
-
Verified V +2
- Frank Nägler +2
- Christian Kuhn +1
Issues 2
Files 3
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php2+5 −3
- typo3/sysext/core/Tests/Unit/Configuration/TypoScript/ConditionMatching/Fixtures/ConditionMatcherUserFuncs.php+5 −0
- typo3/sysext/core/Tests/Unit/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcherTest.php+208 −0
Review log 17
-
Gernot Leitgab uploaded patch set 1 01/25/16, 18:28
-
Frank Nägler wrote 01/25/16, 18:44
Patch set 2: Commit message was updated. -
Frank Nägler voted on patch set 2 CR +1 V +1 01/25/16, 18:44
-
Frank Nägler commented on patch set 2 CR -1 01/25/16, 18:48
on it, will add some unit tests -
Frank Nägler commented on patch set 2 V -1 01/25/16, 18:56
new unit tests fail with current implementation, will push an update -
Frank Nägler uploaded patch set 3 01/25/16, 20:05
-
Frank Nägler commented on patch set 3 CR +1 V +1 01/25/16, 20:08
ok, while adding the new unit tests, I found another bug in the parser method. This bug is now also fixed. Please test this patch really carefully. I would like to see a review bei Lolli specially for the new unit tests. -
Sascha Egerer commented on patch set 3 CR -1 01/26/16, 10:06
AbstractConditionMatcher.php:344We should add a trim() when doing a strict type string comparison as `foo:bar( )` will return `" "` as value -
Frank Nägler commented on patch set 3 01/26/16, 10:13
AbstractConditionMatcher.php:344Replyagree, but my refactoring should also return an empty array. can't test is yet, maybe this could be another new unit test :) -
Sascha Egerer commented on patch set 3 01/26/16, 10:20
I'll push an update. -
Sascha Egerer uploaded patch set 4 01/26/16, 10:44
-
Christian Kuhn commented on patch set 4 01/26/16, 11:44
will review -
Frank Nägler voted on patch set 4 CR +1 V +1 02/01/16, 10:26
-
Christian Kuhn voted on patch set 4 CR +1 V +1 02/01/16, 12:19
-
Frank Nägler voted on patch set 4 CR +2 V +2 02/01/16, 12:32
-
Gerrit merged patch set 4 02/01/16, 12:32
-
Frank Nägler commented on patch set 5 02/01/16, 12:33
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 0509f9e1fb54f097b28d21661c6d7a7b02bd1c9b