46235[BUGFIX] Possible division by zero in PaginateController
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Georg Ringer +1
- Wouter Wolters +1
- Eric Chavaillaz +1
-
Verified V +2
- Xavier Perseguers +2
- Georg Ringer +1
- Eric Chavaillaz +1
Issues 1
Files 2
Review log 9
-
Xavier Perseguers uploaded patch set 1 01/26/16, 08:48
-
Xavier Perseguers uploaded patch set 2 01/26/16, 09:20
-
Sascha Egerer commented on patch set 2 01/26/16, 09:54
-
Xavier Perseguers commented on patch set 2 01/26/16, 10:25
PaginateController.php:67Replymy fix removes the warning in PHP7 and there is no sense allowing negative values so I don't consider your proposal as better -
Wouter Wolters voted on patch set 2 CR +1 01/28/16, 22:40
-
Georg Ringer voted on patch set 2 CR +1 V +1 01/29/16, 04:43
-
Eric Chavaillaz voted on patch set 2 CR +1 V +1 01/29/16, 08:52
-
Xavier Perseguers voted on patch set 2 CR +2 V +2 01/29/16, 08:52
-
Gerrit merged patch set 2 01/29/16, 08:52
PaginateController.php:67