Review main Merged

46235[BUGFIX] Possible division by zero in PaginateController

Xavier Perseguers CR +2 V +2 Easy +4 −2 updated 01/29/16, 08:52

Commit message

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Eric Chavaillaz +1
  • Verified V +2
    • Xavier Perseguers +2
    • Georg Ringer +1
    • Eric Chavaillaz +1

Issues 1

Files 2

Review log 9

  1. Xavier Perseguers uploaded patch set 1 01/26/16, 08:48

  2. Xavier Perseguers uploaded patch set 2 01/26/16, 09:20

  3. Sascha Egerer commented on patch set 2 01/26/16, 09:54

    PaginateController.php:67

    Would also check if the array key exists. What abaout this? $this->numberOfPages = !empty($this->configuration['itemsPerPage']) ? ceil($this->numberOfObjects / (int)$this->configuration['itemsPerPage']) : 0;
  4. Xavier Perseguers commented on patch set 2 01/26/16, 10:25

    PaginateController.php:67 Reply

    my fix removes the warning in PHP7 and there is no sense allowing negative values so I don't consider your proposal as better
  5. Wouter Wolters voted on patch set 2 CR +1 01/28/16, 22:40

  6. Georg Ringer voted on patch set 2 CR +1 V +1 01/29/16, 04:43

  7. Eric Chavaillaz voted on patch set 2 CR +1 V +1 01/29/16, 08:52

  8. Xavier Perseguers voted on patch set 2 CR +2 V +2 01/29/16, 08:52

  9. Gerrit merged patch set 2 01/29/16, 08:52