Review main Merged

46241[BUGFIX] Allow empty values for js language labels

Thomas Schlumberger CR +2 V +2 Easy +5 −1 updated 01/26/16, 12:49

Commit message

When a user has a translated backend where not all
labels are translated, Lang.js throws an js exception
for accessing empty values.

The check for empty values therefor must be hardened.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Gorges +1
  • Verified V +2
    • Benni Mack +2
    • Daniel Gorges +1

Issues 1

Files 1

Review log 6

  1. Thomas Schlumberger uploaded patch set 1 01/26/16, 11:54

  2. Benni Mack commented on patch set 1 CR +1 V +1 01/26/16, 11:55

    Just set up the backend with "german" and try to upload a file via FormEngine (tt_content.textpic) for instance.
  3. Daniel Gorges voted on patch set 1 CR +1 V +1 01/26/16, 12:47

  4. Benni Mack voted on patch set 1 CR +2 V +2 01/26/16, 12:49

  5. Gerrit merged patch set 1 01/26/16, 12:49

  6. Benni Mack commented on patch set 2 01/26/16, 12:49

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 4128634deb0a61cef918e53c23ed5ac50f83fcdf