46264[BUGFIX] Clear cache system icon is shown for non admin in dev context
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Georg Ringer +1
- Wouter Wolters +1
-
Verified V +2
- Benni Mack +2
- Georg Ringer +1
- Wouter Wolters +1
Issues 1
Files 1
Review log 11
-
Eric Chavaillaz uploaded patch set 1 01/27/16, 13:00
-
Wouter Wolters commented on patch set 1 CR -1 01/27/16, 13:04
IMO not a problem. Is there a reason this is problematic for you? -
Eric Chavaillaz commented on patch set 1 01/27/16, 13:08
I think that for a non admin it should be set explicitly in the userTS for the system icon, even in dev context. -
Xavier Perseguers commented on patch set 1 01/27/16, 13:34
I agree with Eric here. I don't see a reason for showing that to non-administrators if they were not explicitly granted access to it, even in development context. Just think about having to switch the context for a while to debug something, currently you open up the system to anyone :( -
Eric Chavaillaz updated the commit message in patch set 2 01/27/16, 13:53
-
Eric Chavaillaz uploaded patch set 3 01/27/16, 14:03
-
Wouter Wolters voted on patch set 3 CR +1 V +1 01/28/16, 22:39
-
Georg Ringer voted on patch set 3 CR +1 V +1 01/29/16, 04:46
-
Benni Mack voted on patch set 3 CR +2 V +2 01/29/16, 08:55
-
Gerrit merged patch set 3 01/29/16, 08:55
-
Benni Mack commented on patch set 4 01/29/16, 08:55
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 1a9702a102e4acf3de5db8242b81fedece998e66