Review main Merged

46273[BUGFIX] Set page title for record list

Christian Weiske CR +2 V +2 Easy +4 −2 updated 03/18/16, 08:09

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Frans Saris +1
  • Verified V +2
    • Andreas Kienast +2
    • Frans Saris +1

Issues 1

Files 1

Review log 14

  1. Christian Weiske uploaded patch set 1 01/28/16, 10:40

  2. Georg Ringer commented on patch set 1 01/29/16, 04:48

    OuterWrapContainer.php:37

    don't like the public property. really needed? use a setter

    OuterWrapContainer.php:120

    don't like that eiter
  3. Christian Weiske commented on patch set 1 01/29/16, 05:09

    If I'd introduce a getter method, the public API would change and it could not be part of 7.6 anymore because of BC considerations. I also don't like the decoding, but the alternative is walking through all the sL and other labeling calls and removing the true parameter, and considering what effect that has on the sprintfs and so.
  4. Benni Mack commented on patch set 1 02/29/16, 20:10

    can't we just use PageRenderer->setTitle() ?
  5. Helmut Hummel commented on patch set 1 CR -1 V -1 02/29/16, 21:34

    EditDocumentController.php:1139

    page title should be calculated here, and not derived from container. In 6.2 it is just the label "TYPO3 Edit Document"

    OuterWrapContainer.php:37 Reply

    ack, but a getter would be needed

    OuterWrapContainer.php:120 Reply

    It is a hack which won't work anyway. $pageTitle might contain valid HTML tags at this point, which would stay untouched by the htmlspecialchars_decode call but be encoded in ModuleTemplate when rendering the HTML title. With the current code, there is no way to properly derive a proper HTML title attribute here
  6. Helmut Hummel commented on patch set 1 02/29/16, 21:35

    RecordList.php:472

    These changes would be fine though
  7. Helmut Hummel wrote 03/08/16, 11:00

    Removed the following votes: * Code-Review-1 by Helmut Hummel <helmut.hummel@typo3.org> * Verified-1 by Helmut Hummel <helmut.hummel@typo3.org>
  8. Christian Weiske uploaded patch set 2 03/17/16, 08:48

  9. Christian Weiske commented on patch set 2 03/17/16, 08:49

    I've reduced the patch to fix the record list only, since the edit document title is not really fixable right now with the amount of work I'll invest here.
  10. Frans Saris voted on patch set 2 CR +1 V +1 03/17/16, 10:47

  11. Andreas Kienast voted on patch set 2 CR +1 03/17/16, 15:34

  12. Andreas Kienast voted on patch set 2 CR +2 V +2 03/18/16, 08:08

  13. Gerrit merged patch set 2 03/18/16, 08:08

  14. Andreas Kienast commented on patch set 3 03/18/16, 08:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 62fa710709fd71c3e7c17620ac83a7bb6ac518b5