Review main Merged

46292[TASK] Remove suggestions info from PackageStates.php

Benni Mack CR +2 V +2 Easy +4 −2 updated 01/28/16, 19:36

Commit message

Suggestions just like dependencies are only needed
when re-ordering the PackageStates.php file, and thus don't
need to be loaded on each request.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1

Issues 1

Files 2

Review log 7

  1. Benni Mack uploaded patch set 1 01/28/16, 17:48

  2. Wouter Wolters commented on patch set 1 CR +1 V +1 01/28/16, 17:52

    suggestions don't end up in PackageStates.php
  3. Andreas Kienast commented on patch set 1 V -1 01/28/16, 18:24

    unit tests fail
  4. Andreas Kienast uploaded patch set 2 01/28/16, 18:27

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 01/28/16, 18:27

  6. Wouter Wolters voted on patch set 2 CR +2 V +2 01/28/16, 19:36

  7. Gerrit merged patch set 2 01/28/16, 19:36