Review main Merged

46337[BUGFIX] Inline record in Flexform can attach new record

Nicole Hummel CR +2 V +2 Easy +5 −5 updated 03/04/16, 10:23

Commit message

If you click the "create new element" button on an inline record within
a FlexForm field, the passed data information contains the id after
which the new element should be inserted. Currently this id isn't
respected while receiving the configuration from the given data. This
patch adds code to respect a possible given id and allows to fetch
configuration for that element as well.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Benni Mack +2
    • Morton Jonuschat +1
  • Verified V +2
    • Nicole Hummel +2
    • Benni Mack +2
    • Morton Jonuschat +1

Issues 1

Files 1

Review log 11

  1. Nicole Hummel uploaded patch set 1 01/29/16, 10:36

  2. Nicole Hummel commented on patch set 1 V -1 01/29/16, 10:52

    Have to push another update
  3. Nicole Hummel uploaded patch set 2 01/29/16, 10:57

  4. Christian Kuhn commented on patch set 2 01/29/16, 11:58

    sounds legit on reading and impact should be restricted to flex.
  5. Morton Jonuschat rebased onto patch set 3 02/12/16, 10:07

  6. Morton Jonuschat voted on patch set 3 CR +1 V +1 02/12/16, 10:07

  7. Benni Mack voted on patch set 3 CR +2 V +2 03/04/16, 10:13

  8. Nicole Hummel voted on patch set 3 CR +2 V +2 03/04/16, 10:15

  9. Gerrit merged patch set 3 03/04/16, 10:15

  10. Nicole Hummel commented on patch set 4 03/04/16, 10:15

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 27414cef8bc6d1b99dee9d2c444f6e9328d9b2bf
  11. Christian Kuhn commented on patch set 4 03/04/16, 10:23

    thx!