Review main Merged

46340[BUGFIX] Failing Unit Tests on Windows systems

Nicole Hummel CR +2 V +2 Easy +5 −4 updated 02/11/16, 21:58

Commit message

Due to realpath usage some Unit Tests are failing on Windows systems.
The tests have to ensure that forward slashes are used for comparison.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Markus Sommer +1
    • Daniel Maier +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Maier +1

Issues 1

Files 1

Review log 13

  1. Nicole Hummel uploaded patch set 1 01/29/16, 11:57

  2. Wouter Wolters voted on patch set 1 CR +1 01/29/16, 11:59

  3. Andreas Kienast voted on patch set 1 CR +1 01/29/16, 12:02

  4. Helmut Hummel voted on patch set 1 CR +2 01/29/16, 12:04

  5. Markus Sommer voted on patch set 1 CR +1 01/29/16, 13:17

  6. Xavier Perseguers commented on patch set 1 CR -1 02/01/16, 13:14

    Where does this fixWindowsFilePath() method comes from?
  7. Xavier Perseguers commented on patch set 1 CR 0 02/01/16, 13:15

    strange, PhpStorm did not find it at first
  8. Nicole Hummel commented on patch set 1 02/01/16, 13:19

    As you can see, this is definied in GeneralUtility since ever...
  9. Daniel Maier commented on patch set 1 CR +1 V +1 02/02/16, 20:49

    Tested on Windows -> all tests in FileBackendTest are green now
  10. Oliver Klee voted on patch set 1 CR +1 02/03/16, 10:27

  11. Wouter Wolters voted on patch set 1 V +2 02/11/16, 21:58

  12. Gerrit merged patch set 1 02/11/16, 21:58

  13. Wouter Wolters commented on patch set 2 02/11/16, 21:58

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit d665e2c82fd8f4858b374a953dba96952581d708