Review TYPO3_6-2 Abandoned

46356[BUGFIX] Remove composer evaluation for dependencies/suggestions

Benni Mack CR 0 V 0 Easy +10 −10 updated 05/11/16, 12:11

Commit message

Currently in 6.2, if an extension author defined a composer.json
then dependencies, version or suggestions were taken from there,
instead of using ext_emconf.php.

The evaluation is removed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 11

  1. Benni Mack uploaded patch set 1 01/29/16, 15:00

  2. Daniel Maier voted on patch set 1 CR +1 01/29/16, 18:04

  3. Helmut Hummel commented on patch set 1 CR -1 01/29/16, 20:19

    This cannot work imho. The flags from the composer manifest will not be loaded any more with this change
  4. Helmut Hummel uploaded patch set 2 01/29/16, 21:03

  5. Benni Mack commented on patch set 2 03/06/16, 10:26

    is this still needed? Should we continue on this one, Nicole and Helmut?
  6. Helmut Hummel commented on patch set 2 03/06/16, 12:36

    it would imho ease the composer integration with TYPO3 6.2
  7. Mathias Brodala commented on patch set 2 V -1 05/11/16, 10:27

    Unfortunately this results also in sysext requirements on "typo3/cms-core" to be ignored and thus EXT:core not being placed first in PackageStates.php anymore, thus e.g. the Page module is missing afterwards. The proper fix would be to add "core" to the ext_emconf.php of all system extensions but I'm not sure about 3rd party extensions.
  8. Helmut Hummel commented on patch set 2 CR -2 05/11/16, 10:34

    Ok. Thanks for the test. Seems like we cannot easily do this and we should probably not waste our time by further looking for a sulution
  9. Helmut Hummel abandoned the change 05/11/16, 10:34

  10. Mathias Brodala commented on patch set 2 05/11/16, 10:42

    Well, the proper fix would be copying the requirements within composer.json of all system extensions to their ext_emconf.php. This way we can ensure the current order is kept intact.
  11. Mathias Brodala commented on patch set 2 05/11/16, 12:11