46367[!!!][TASK] Fluidification of Clipboard
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Markus Sommer +1
- Florian Mast +1
-
Verified V +2
- Anja Leichsenring +2
- Markus Sommer +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php2+134 −152
- typo3/sysext/backend/Resources/Private/Partials/Clipboard/CopymodeSelector.htmlnew+17 −0
- typo3/sysext/backend/Resources/Private/Partials/Clipboard/MenuSelector.htmlnew+14 −0
- typo3/sysext/backend/Resources/Private/Partials/Clipboard/Tab.htmlnew+28 −0
- typo3/sysext/backend/Resources/Private/Partials/Clipboard/TabContent.htmlnew+41 −0
- typo3/sysext/backend/Resources/Private/Templates/Clipboard/Main.htmlnew+34 −0
- typo3/sysext/core/Documentation/Changelog/master/Breaking-73016-RenamingOfClipboard-printContentFromTabToGetContentFromTab.rstnew+32 −0
Review log 3044
Show 1419 earlier messages
-
Jan Helke uploaded patch set 1 01/29/16, 17:33
-
Jan Helke uploaded patch set 2 01/29/16, 17:44
-
Jan Helke uploaded patch set 3 02/12/16, 18:17
-
Jan Helke uploaded patch set 4 03/03/16, 14:23
-
Jan Helke uploaded patch set 5 03/03/16, 22:38
-
Jan Helke uploaded patch set 6 03/04/16, 15:25
-
Jan Helke uploaded patch set 7 03/04/16, 16:37
-
Jan Helke uploaded patch set 8 09/02/16, 19:50
-
Jan Helke uploaded patch set 9 09/02/16, 19:55
-
Jan Helke uploaded patch set 10 12/01/16, 12:43
-
TYPO3com voted on patch set 10 V -1 12/01/16, 12:43 Completed build in 07s on Thu, 1 Dec, 01:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5240
-
Jan Helke uploaded patch set 11 12/01/16, 14:34
-
TYPO3com voted on patch set 11 V -1 12/01/16, 14:34 Completed build in 08s on Thu, 1 Dec, 03:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5247
-
Jan Helke uploaded patch set 12 12/01/16, 16:30
-
TYPO3com voted on patch set 12 V -1 12/01/16, 16:30 Completed build in 08s on Thu, 1 Dec, 05:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5261
-
Jan Helke uploaded patch set 13 12/01/16, 16:49
-
Jan Helke uploaded patch set 14 12/01/16, 16:51
-
TYPO3com voted on patch set 13 V -1 12/01/16, 16:54 Completed build in 04m 58s on Thu, 1 Dec, 05:54 PM Test Summary: 54089 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5266
-
TYPO3com voted on patch set 14 V -1 12/01/16, 16:56 Completed build in 05m 12s on Thu, 1 Dec, 05:56 PM Test Summary: 54089 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5267
-
Jan Helke uploaded patch set 15 12/01/16, 17:06
-
TYPO3com voted on patch set 15 V -1 12/01/16, 17:13 Completed build in 06m 56s on Thu, 1 Dec, 06:13 PM Test Summary: 54089 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5272
-
Jan Helke rebased onto patch set 16 12/01/16, 17:18
-
TYPO3com voted on patch set 16 V -1 12/01/16, 17:22 Completed build in 04m 08s on Thu, 1 Dec, 06:22 PM Test Summary: 54089 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5274
-
Jan Helke commented on patch set 17 12/01/16, 17:28
Published edit on patch set 16. -
Jan Helke updated the commit message in patch set 18 12/01/16, 17:28
-
TYPO3com voted on patch set 17 V -1 12/01/16, 17:33 Completed build in 04m 25s on Thu, 1 Dec, 06:33 PM Test Summary: 54089 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5275
-
TYPO3com voted on patch set 18 V -1 12/01/16, 17:33 Completed build in 04m 49s on Thu, 1 Dec, 06:33 PM Test Summary: 54089 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5276
-
Jan Helke commented on patch set 19 12/01/16, 18:14
Published edit on patch set 18. -
TYPO3com voted on patch set 19 V +1 12/01/16, 18:19 Completed build in 05m 11s on Thu, 1 Dec, 07:19 PM Test Summary: 54089 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5280
-
Jan Helke uploaded patch set 20 12/01/16, 18:29
-
Jan Helke uploaded patch set 21 12/01/16, 18:30
-
TYPO3com voted on patch set 20 V +1 12/01/16, 18:33 Completed build in 04m 30s on Thu, 1 Dec, 07:33 PM Test Summary: 54089 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5283
-
TYPO3com voted on patch set 21 V +1 12/01/16, 18:35 Completed build in 04m 41s on Thu, 1 Dec, 07:35 PM Test Summary: 54089 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5284
-
Valentin Funk commented on patch set 21 12/01/16, 20:07
A question about naming.Clipboard.php:1105why not as described: getStandaloneView() ? Or because it does mostly others than create a new instance: initializeStandaloneView()? The view itself may also instantiated in the constructor. -
Jan Helke uploaded patch set 22 12/02/16, 09:45
-
Jan Helke commented on patch set 21 12/02/16, 09:46
Clipboard.php:1105ReplyAgree about the naming. Changed it. -
TYPO3com voted on patch set 22 V +1 12/02/16, 09:51 Completed build in 05m 39s on Fri, 2 Dec, 10:51 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5309
-
Jan Helke updated the commit message in patch set 23 12/02/16, 15:38
-
TYPO3com voted on patch set 23 V +1 12/02/16, 15:43 Completed build in 05m 17s on Fri, 2 Dec, 04:43 PM Test Summary: 54119 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5346
-
Florian Mast voted on patch set 23 CR +1 12/02/16, 17:15
-
Anja Leichsenring voted on patch set 23 CR +1 V +1 12/03/16, 09:39
-
Markus Sommer commented on patch set 23 CR +1 V +1 12/03/16, 10:01
Works like a god -
Anja Leichsenring voted on patch set 23 CR +2 V +2 12/03/16, 10:17
-
Gerrit merged patch set 23 12/03/16, 10:17