46376[TASK] Remove @inject from ext:fluid
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Daniel Goerz +1
- Morton Jonuschat +1
-
Verified V +2
- Wouter Wolters +2
- Daniel Goerz +1
- Morton Jonuschat +1
Issues 1
Files 12
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php5+16 −2
- typo3/sysext/fluid/Classes/Core/ViewHelper/AbstractViewHelper.php+8 −1
- typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetViewHelper.php1+9 −3
- typo3/sysext/fluid/Classes/Core/Widget/WidgetRequestHandler.php+24 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Widget/PaginateViewHelper.php+8 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+8 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+8 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormViewHelper.php+8 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/AutocompleteViewHelper.php3+8 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/PaginateViewHelper.php+8 −1
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+24 −3
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php+8 −1
Review log 19
-
Wouter Wolters uploaded patch set 1 01/29/16, 19:00
-
Wouter Wolters uploaded patch set 2 01/29/16, 19:02
-
Mathias Brodala commented on patch set 2 01/30/16, 09:10
-
Wouter Wolters commented on patch set 2 01/30/16, 16:58
RenderingContext.php:103ReplyIMO no. this is only used once here. -
Mathias Brodala commented on patch set 2 01/30/16, 17:22
RenderingContext.php:103ReplyI'd argue that classes should always be imported, even if used only once. If the relative classname resolving patch is merged, the type hint will be shortened too. -
Wouter Wolters commented on patch set 2 01/30/16, 18:33
RenderingContext.php:103Replythis was a decision from the core team to not import all used classes. -
Mathias Brodala commented on patch set 2 CR -1 01/30/16, 18:40
RenderingContext.php:103ReplyDone -
Mathias Brodala commented on patch set 2 CR +1 01/30/16, 19:21
Wrong vote, sorry. -
Daniel Goerz voted on patch set 2 CR +1 V +1 02/01/16, 17:42
-
Markus Klein commented on patch set 2 02/03/16, 15:07
AutocompleteViewHelper.php:54shouldn't this name match the variable name? -
Claus Due commented on patch set 2 02/08/16, 17:08
AutocompleteViewHelper.php:54ReplyI think it would cause a signature mismatch error on php7. -
Daniel Goerz commented on patch set 2 02/08/16, 17:14
AutocompleteViewHelper.php:54ReplyMarkus wants to rename this method to injectController, which does not make much of a difference for me. -
Helmut Hummel commented on patch set 2 02/08/16, 17:22
this should imho also go into 7.6 branch -
Claus Due commented on patch set 2 02/08/16, 18:05
AbstractWidgetViewHelper.php:27This line also needs to be changed. -
Wouter Wolters wrote 02/09/16, 08:35
Patch set 3: Published edit on patch set 2. -
Daniel Goerz voted on patch set 3 CR +1 V +1 02/09/16, 08:43
-
Morton Jonuschat voted on patch set 3 CR +1 V +1 02/11/16, 06:29
-
Wouter Wolters voted on patch set 3 CR +2 V +2 02/11/16, 07:50
-
Gerrit merged patch set 3 02/11/16, 07:50
RenderingContext.php:103