Review main Merged

46376[TASK] Remove @inject from ext:fluid

Wouter Wolters CR +2 V +2 Normal +137 −19 updated 02/11/16, 07:50

Commit message

Use inject methods instead.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Morton Jonuschat +1

Issues 1

Files 12

Review log 19

  1. Wouter Wolters uploaded patch set 1 01/29/16, 19:00

  2. Wouter Wolters uploaded patch set 2 01/29/16, 19:02

  3. Mathias Brodala commented on patch set 2 01/30/16, 09:10

    RenderingContext.php:103

    Can we "use" the type hints here?
  4. Wouter Wolters commented on patch set 2 01/30/16, 16:58

    RenderingContext.php:103 Reply

    IMO no. this is only used once here.
  5. Mathias Brodala commented on patch set 2 01/30/16, 17:22

    RenderingContext.php:103 Reply

    I'd argue that classes should always be imported, even if used only once. If the relative classname resolving patch is merged, the type hint will be shortened too.
  6. Wouter Wolters commented on patch set 2 01/30/16, 18:33

    RenderingContext.php:103 Reply

    this was a decision from the core team to not import all used classes.
  7. Mathias Brodala commented on patch set 2 CR -1 01/30/16, 18:40

    RenderingContext.php:103 Reply

    Done
  8. Mathias Brodala commented on patch set 2 CR +1 01/30/16, 19:21

    Wrong vote, sorry.
  9. Daniel Goerz voted on patch set 2 CR +1 V +1 02/01/16, 17:42

  10. Markus Klein commented on patch set 2 02/03/16, 15:07

    AutocompleteViewHelper.php:54

    shouldn't this name match the variable name?
  11. Claus Due commented on patch set 2 02/08/16, 17:08

    AutocompleteViewHelper.php:54 Reply

    I think it would cause a signature mismatch error on php7.
  12. Daniel Goerz commented on patch set 2 02/08/16, 17:14

    AutocompleteViewHelper.php:54 Reply

    Markus wants to rename this method to injectController, which does not make much of a difference for me.
  13. Helmut Hummel commented on patch set 2 02/08/16, 17:22

    this should imho also go into 7.6 branch
  14. Claus Due commented on patch set 2 02/08/16, 18:05

    AbstractWidgetViewHelper.php:27

    This line also needs to be changed.
  15. Wouter Wolters wrote 02/09/16, 08:35

    Patch set 3: Published edit on patch set 2.
  16. Daniel Goerz voted on patch set 3 CR +1 V +1 02/09/16, 08:43

  17. Morton Jonuschat voted on patch set 3 CR +1 V +1 02/11/16, 06:29

  18. Wouter Wolters voted on patch set 3 CR +2 V +2 02/11/16, 07:50

  19. Gerrit merged patch set 3 02/11/16, 07:50