46395[BUGFIX] Avoid memory leak during file searches
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frank Nägler +1
- Daniel Maier +1
-
Verified V +2
- Christian Kuhn +2
- Daniel Maier +1
Issues 1
Files 2
Review log 9
-
Alexander Schnitzler uploaded patch set 1 01/30/16, 14:43
-
Mathias Brodala commented on patch set 1 01/30/16, 22:47
whoseFileIndexRepository.php:209Please make this the 2nd argument; this class is described "for internal use only" so this would be no API breakage. -
Frank Nägler commented on patch set 1 CR +1 02/29/16, 13:26
FileIndexRepository.php:209Replythe class is not annotated with @internal so this parameter must be added to the end of this public function. -
Mathias Brodala commented on patch set 1 02/29/16, 13:57
FileIndexRepository.php:209ReplyI understand that but what about what I wrote? I'd say the missing @internal is a bug then. -
Daniel Maier voted on patch set 1 CR +1 V +1 03/04/16, 18:50
-
Christian Kuhn commented on patch set 1 03/04/16, 18:59
this is significantly quicker.FileIndexRepository.php:209Replythis could be changed with another patch. -
Christian Kuhn voted on patch set 1 CR +2 V +2 03/04/16, 19:04
-
Gerrit merged patch set 1 03/04/16, 19:04
-
Christian Kuhn commented on patch set 2 03/04/16, 19:05
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 16ff344b4cd5a02dca026000bb97060fe5174ef2