Review main Abandoned

46410[WIP][FEATURE] Add Puli support for TYPO3

Benni Mack CR 0 V 0 Expert +1560 −97 updated 02/15/16, 15:56

Commit message

The PHP package puli allows to freely choose e.g. the location of
typo3/sysext/ files, and allows for further mappings so e.g.
typo3conf/LocalConfiguration.php can be moved to any directory
if puli.json of a custom project is used to be e.g. put outside of the webroot.

I introduced a small hack to allow puli also for non-composer-mode
parameters, and a decorator factory class to be used in TYPO3.

I also want to measure performance and maybe use streamwrappers.

Review

  • Code review CR 0
  • Verified V 0

Files 9

Review log 4

  1. Benni Mack uploaded patch set 1 01/30/16, 19:21

  2. Benni Mack commented on patch set 1 01/30/16, 19:22

    Initializing Puli Factory + Repository takes 0.001s on my machine.
  3. Mathias Brodala commented on patch set 1 01/30/16, 19:50

    Factory.php:72

    You can use ResourceRepository::class here

    GeneralUtility.php:3562

    This should also use "static::isFirstPartOfStr"
  4. Benni Mack abandoned the change 02/15/16, 15:56

    As Puli is for reading only, I don't see how we can use this for our "Management" tool right now.