Review main Abandoned

46419[WIP][FEATURE] Introduce System Environment

Benni Mack CR 0 V 0 Normal +164 −32 updated 05/03/16, 09:23

Commit message

Usable API class to be used to work better
with custom composer options.

ToDo:
- Documentation as RST

Review

  • Code review CR 0
  • Verified V 0

Files 5

Review log 12

  1. Benni Mack uploaded patch set 1 01/31/16, 12:20

  2. Mathias Brodala uploaded patch set 2 01/31/16, 13:08

  3. Benni Mack uploaded patch set 3 02/16/16, 18:37

  4. Benni Mack commented on patch set 3 04/18/16, 11:25

    I will update the patch with the following ENV variables to be set: - Environment variables TYPO3_CONTEXT TYPO3_PATH_ROOT (defaults to PATH_SITE or set from composer installer) TYPO3_PATH_SITE (defaults to PATH_SITE) TYPO3_PATH_BACKEND (defaults to PATH_SITE/typo3/) TYPO3_PATH_CONF (defaults to PATH_SITE/typo3conf/) TYPO3_PATH_VAR (defaults to PATH_SITE/typo3temp/var/) maybe: TYPO3_PATH_CACHE (defaults to PATH_SITE/typo3temp/var/) TYPO3_PATH_LOG (defautls to PATH_SITE/typo3temp/var/logs/) Environment variables for DB settings can be used in TYPO3_CONF_VARS easily
  5. Benni Mack uploaded patch set 4 04/18/16, 18:01

  6. Benni Mack updated the commit message in patch set 5 04/18/16, 18:02

  7. Benni Mack commented on patch set 6 04/19/16, 10:09

    Published edit on patch set 5.
  8. Benni Mack commented on patch set 7 04/19/16, 10:10

    Published edit on patch set 6.
  9. Benni Mack uploaded patch set 8 04/20/16, 10:06

  10. Mathias Brodala commented on patch set 8 04/20/16, 10:13

    SystemEnvironment.php:66

    I know that this pattern is already used a few times but wouldn't GeneralUtility::makeInstance(SystemEnvironment::class) be more consistent?
  11. Benni Mack updated the commit message in patch set 9 04/20/16, 10:38

  12. Benni Mack abandoned the change 05/03/16, 09:23

    I'll use another approach.