Review main Merged

46425[TASK] Do not hide possible PHP warning from Extbase exception

Xavier Perseguers CR +2 V +2 Easy +1 −1 updated 02/03/16, 08:32

Commit message

The Extbase ClassInfoFactory may be unable to build information for a
given class if a PHP warning occurs while running in development context.

Instead of hiding the actual exception with a generic message
"Could not analyse class: VendorName\ExtensionKey\Some\Class", it should
include the message of the corresponding exception to give useful advice
while fixing the problem.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Eric Chavaillaz +1
    • Andreas Kienast +1
    • Mathias Brodala +1
  • Verified V +2
    • Xavier Perseguers +2
    • Eric Chavaillaz +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 12

  1. Xavier Perseguers uploaded patch set 1 02/01/16, 09:17

  2. Georg Ringer voted on patch set 1 CR +1 V +1 02/01/16, 09:23

  3. Eric Chavaillaz voted on patch set 1 CR +1 02/01/16, 13:37

  4. Xavier Perseguers voted on patch set 1 CR +2 02/01/16, 18:34

  5. Mathias Brodala commented on patch set 1 02/03/16, 08:28

    ClassInfoFactory.php:37

    Please also add the original exception as last parameter here.
  6. Mathias Brodala wrote 02/03/16, 08:29

    Patch set 2: Published edit on patch set 1.
  7. Andreas Kienast voted on patch set 2 CR +1 V +1 02/03/16, 08:30

  8. Mathias Brodala voted on patch set 2 CR +1 02/03/16, 08:30

  9. Eric Chavaillaz voted on patch set 2 CR +1 V +1 02/03/16, 08:31

  10. Xavier Perseguers commented on patch set 2 CR +2 V +2 02/03/16, 08:32

    thanks for reviewing
  11. Gerrit merged patch set 2 02/03/16, 08:32

  12. Xavier Perseguers commented on patch set 3 02/03/16, 08:32

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit c5b6ad433f7bdfe5183e28fee433fe7e15a147c1