Review TYPO3_6-2 Merged

46428[BUGFIX] Reallow '0' as valid userFunc argument in TypoScript

Frank Nägler CR +2 V +2 Hard +258 −7 updated 02/01/16, 14:24

Commit message

With #47301 the parsing of userFunc in TypoScript has changed.
The change prevents '0' as valid argument.

This patch fix the '0' bug but also adds some new unit tests.
The parser method also includes a bug with quoted values which are not the
last argument. this bug is now fixed too.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 2

Files 3

Review log 5

  1. Frank Nägler uploaded patch set 1 02/01/16, 13:32

  2. Frank Nägler commented on patch set 1 V -1 02/01/16, 13:32

    unit test failed
  3. Frank Nägler uploaded patch set 2 02/01/16, 14:20

  4. Christian Kuhn voted on patch set 2 CR +2 V +2 02/01/16, 14:24

  5. Gerrit merged patch set 2 02/01/16, 14:24