Review main Abandoned

46432[TASK] Rename extension:dumpclassloadinginformation to extension:dumpautoload

Mathias Brodala CR 0 V 0 Easy +28 −0 updated 03/29/17, 07:57

Commit message

The old name is hard to type and remember. Since this command basically
does the same as "composer dumpautoload", it should be named accordingly.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1213

  1. Mathias Brodala uploaded patch set 1 02/01/16, 15:05

  2. Morton Jonuschat commented on patch set 1 CR -1 02/01/16, 15:10

    I'm fine with deprecating it, but I'd advocate replacing it with a direct command for t3console without hiding it below "extbase" - see https://review.typo3.org/#/c/45581/
  3. Mathias Brodala commented on patch set 1 02/01/16, 15:14

    Good idea, I'll look into it. I'm used to the typo3_console where the "extbase" is not necessary anyways. ;-)
  4. Benni Mack commented on patch set 1 CR -1 03/03/16, 18:09

    I also think this should be handled differently - maybe deprecate the old stuff and just use a Symfony Command now?
  5. Mathias Brodala commented on patch set 1 03/04/16, 08:50

    > I also think this should be handled differently - maybe deprecate > the old stuff and just use a Symfony Command now? That's what Morton suggested yeah. Question is if the embedded Composer class loading will be kept for 8.x or dropped.
  6. Benni Mack commented on patch set 1 04/01/16, 09:09

    we will keep the non-composer mode for at least the next 6 months. however, I don't see the real big benefit currently.
  7. Wouter Wolters commented on patch set 1 06/07/16, 20:41

    ping; what is the next action here?
  8. Mathias Brodala commented on patch set 1 06/08/16, 07:30

    > ping; what is the next action here? If this has a chance for getting accepted at all, it should be done with a Symfony command instead.
  9. Morton Jonuschat wrote 08/04/16, 15:37

    Removed the following votes: * Code-Review-1 by Morton Jonuschat <m.jonuschat@mojocode.de>
  10. TYPO3com voted on patch set 1 V -1 12/04/16, 11:00 Completed build in 17m 59s on Sun, 4 Dec, 12:00 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5464

  11. Benni Mack commented on patch set 1 03/28/17, 19:59

    @mbrodala - are you going to continue with this?
  12. Mathias Brodala commented on patch set 1 03/29/17, 07:31

    > @mbrodala - are you going to continue with this? I plan to but it's not high priority for me ATM since I'm always in Composer Mode.
  13. Benni Mack abandoned the change 03/29/17, 07:57

    Won't implement this for now.