46436[FOLLOWUP][FEATURE] Introduce native support for Symfony Console
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Georg Ringer +1
- Frank Nägler +1
- Andreas Kienast +1
-
Verified V +2
- Benni Mack +2
- Georg Ringer +1
Issues 1
Files 6
Review log 46
Show 21 earlier messages
-
Mathias Brodala uploaded patch set 1 02/01/16, 16:52
-
Daniel Goerz commented on patch set 1 02/01/16, 17:21
Please adjust the RST, too -
Claus Due voted on patch set 1 CR +1 02/01/16, 19:38
-
Benni Mack commented on patch set 1 CR -1 02/02/16, 08:00
The rst should be renamed. I personally like t3console as it shows you that it's a Console mechanism like with symfony console as component as well as their binary (located under app/console). Fine with typo3 though. But rst needs to be adapted. -
Mathias Brodala uploaded patch set 2 02/02/16, 08:11
-
Mathias Brodala commented on patch set 2 02/02/16, 08:11
Updated and cleaned up RST. -
Daniel Goerz voted on patch set 2 CR +1 02/02/16, 08:22
-
Benni Mack commented on patch set 2 02/02/16, 08:54
Feature-73042-IntroduceNativeSupportForSymfonyConsole.rst:42I would actually show the full path here, instead of the shortened. Or even have both examples. -
Mathias Brodala wrote 02/02/16, 09:20
Patch set 3: Published edit on patch set 2. -
Mathias Brodala commented on patch set 2 02/02/16, 09:21
Feature-73042-IntroduceNativeSupportForSymfonyConsole.rst:42ReplyDone -
Daniel Goerz voted on patch set 3 CR +1 02/02/16, 09:37
-
Claus Due voted on patch set 3 CR +1 02/02/16, 10:42
-
Christian Kuhn voted on patch set 3 CR +1 02/02/16, 12:58
-
Peter Foerger voted on patch set 3 CR +1 02/03/16, 09:32
-
Mathias Brodala uploaded patch set 4 02/03/16, 15:54
-
Mathias Brodala commented on patch set 4 02/03/16, 15:54
Rebased to master, please revote. -
Claus Due voted on patch set 4 CR +1 02/03/16, 15:56
-
Daniel Goerz voted on patch set 4 CR +1 02/03/16, 16:01
-
Peter Foerger voted on patch set 4 CR +1 02/03/16, 19:32
-
Claus Due commented on patch set 4 02/04/16, 12:55
"composer install" does not create the link in ./bin for me - am I doing something wrong? -
Claus Due uploaded patch set 5 02/04/16, 12:59
-
Claus Due commented on patch set 4 02/04/16, 12:59
Set +x permission on "typo3" file. -
Mathias Brodala commented on patch set 5 02/04/16, 13:41
> "composer install" does not create the link in ./bin for me - am I > doing something wrong? What have you set in config.bin-dir in your composer.json? If you skip it or use something else, it won't show up in bin. But I'm sure you know that already. ;-) -
Mathias Brodala commented on patch set 5 02/04/16, 13:42
> Set +x permission on "typo3" file. Thanks a lot. I was hoping this wouldn't occur when simply renaming a file but seems like I was wrong. :-( -
Claus Due commented on patch set 4 02/04/16, 13:47
I was just wondering - because in many projects I've come across, people use the composer.json of the core and "composer require" stuff when necessary. In such a setup the "typo3" command would not be available in ./bin. That's one of the reasons why I initially suggested creating this command not in the "core" extension but in ./bin directly (if necessary, as a symlink). -
Mathias Brodala commented on patch set 5 02/04/16, 13:57
> I was just wondering - because in many projects I've come across, > people use the composer.json of the core and "composer require" > stuff when necessary. That's an error then and not how Composer projects work. You should always require typo3/cms as regular dependency. > In such a setup the "typo3" command would not > be available in ./bin. In that case the composer.json was copied incompletely. > That's one of the reasons why I initially suggested creating this > command not in the "core" extension but in ./bin directly (if > necessary, as a symlink). That's the case here though. The script is always created in "bin" if you fetch "typo3/cms" (or "typo3/cms-core") as dependency. -
Benni Mack voted on patch set 5 CR +1 02/05/16, 16:01
-
Mathias Brodala commented on patch set 5 02/05/16, 17:44
> "composer install" does not create the link in ./bin for me - am I > doing something wrong? Could it be that you mean "composer install" after a pull in the TYPO3 repository does not create it? Yes, that's normal since "typo3/cms-core" is not fetched as dependency but embedded. -
Wouter Wolters voted on patch set 5 CR +1 02/05/16, 19:53
-
Claus Due commented on patch set 5 02/05/16, 23:13
I know it's technically an error to use the TYPO3 composer.json but nevertheless, that's what a lot of people have done. The problem probably stems from the old install routine where people downloaded the source and created symlinks. Now they download the source and do "composer install" in it. We could make life easier for those people who have made this mistake rather than just inform them they made a mistake and tell them to restructure their entire composer setup. It's a symlink for us but many hours of corrective surgery for users combined. -
Mathias Brodala commented on patch set 5 02/08/16, 08:30
> We could make life easier for those people who have made this > mistake rather than just inform them they made a mistake and tell > them to restructure their entire composer setup. It's a symlink for > us but many hours of corrective surgery for users combined. What's your idea here? We cannot embed a symlink due to Windows and I would like to avoid duplicating this in typo3/cms-composer-installers. -
Mathias Brodala uploaded patch set 6 02/08/16, 08:42
-
Mathias Brodala commented on patch set 6 02/08/16, 08:42
Rebased to master. -
Georg Ringer voted on patch set 6 CR +1 V +1 02/08/16, 08:44
-
Benni Mack voted on patch set 6 CR +2 02/08/16, 08:45
-
Frank Nägler voted on patch set 6 V +2 02/08/16, 08:46
-
Frank Nägler voted on patch set 6 V 0 02/08/16, 08:47
-
Frank Nägler voted on patch set 6 CR +1 02/08/16, 08:47
-
Frank Nägler commented on patch set 6 CR -1 02/08/16, 08:49
found t3console in some comments in the core -
Frank Nägler uploaded patch set 7 02/08/16, 08:53
-
Andreas Kienast voted on patch set 7 CR +1 02/08/16, 08:54
-
Georg Ringer voted on patch set 7 CR +1 V +1 02/08/16, 08:55
-
Frank Nägler voted on patch set 7 CR +1 02/08/16, 08:56
-
Benni Mack voted on patch set 7 CR +2 V +2 02/08/16, 09:00
-
Gerrit merged patch set 7 02/08/16, 09:00
-
Frank Nägler commented on patch set 7 02/08/16, 09:00
post +1 for verify ;)