Review main Merged

46451[TASK] Cap counter of "Application Overview"

Andreas Kienast CR +2 V +2 Easy +8 −3 updated 02/11/16, 15:09

Commit message

The issue counter of the "Application Overview" menu gets capped if
there are more than 99 issues by appending a "+" sign. This solves a
overflow issue if there are too many "unread" issues, that may occur
e.g. after creating a new admin user.

Review

  • Code review CR +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Wouter Wolters +1

Issues 1

Files 2

Review log 14

  1. Andreas Kienast uploaded patch set 1 02/02/16, 16:54

  2. Andreas Kienast wrote 02/02/16, 16:58

    Patch set 2: Commit message was updated.
  3. Daniel Goerz voted on patch set 2 CR +1 02/02/16, 17:44

  4. Markus Klein commented on patch set 2 02/02/16, 18:23

    SystemInformationToolbarItem.php:354

    How can this condition be ever true, if the totalCount is limited to maxCount in line 302?
  5. Andreas Kienast commented on patch set 2 02/02/16, 18:53

    SystemInformationToolbarItem.php:354 Reply

    This is actually possible, because totalCount is initially 0, but can be larger than maximumCountInBadge after calling emitLoadMessages. The if condition only prevents additional calculations if the limit is already reached.
  6. Markus Klein commented on patch set 2 CR +1 V +1 02/02/16, 22:36

    SystemInformationToolbarItem.php:354 Reply

    You right of course. I overlooked that $message['count'] is of course an arbitrary number and not only 1
  7. Wouter Wolters voted on patch set 2 CR +1 02/05/16, 20:07

  8. Wouter Wolters commented on patch set 2 CR -1 02/10/16, 18:12

    SystemInformationMenu.js:84

    why this change to html() instead of leaving it to text() ?
  9. Wouter Wolters wrote 02/11/16, 07:54

    Patch set 3: Published edit on patch set 2.
  10. Wouter Wolters voted on patch set 3 CR +1 V +1 02/11/16, 07:54

  11. Daniel Goerz voted on patch set 3 CR +1 V +1 02/11/16, 08:04

  12. Markus Klein voted on patch set 3 CR +2 V +2 02/11/16, 15:09

  13. Gerrit merged patch set 3 02/11/16, 15:09

  14. Markus Klein commented on patch set 4 02/11/16, 15:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit e1c90cd5e4348501051b2374740dbef2f19e13e9