Review TYPO3_7-6 Merged

46457[BUGFIX] Solves PHP warning in FileAllowedTypesValidator

Zsolt Molnar CR +2 V +2 Normal +63 −27 updated 03/04/16, 17:44

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 2

Files 2

Review log 8

  1. Zsolt Molnar uploaded patch set 1 02/03/16, 12:30

  2. Wouter Wolters commented on patch set 1 CR -1 02/05/16, 20:10

    FileAllowedTypesValidator.php:72

    this solves the issue but IMO not the correct way. The code here expects an array but on line 49 it expects a comma separated string. both should expect the same input.
  3. Wouter Wolters wrote 02/19/16, 19:36

    Patch set 2: Commit message was updated.
  4. Wouter Wolters commented on patch set 2 02/19/16, 19:36

    Cherry Picked This patchset was cherry picked to branch master as commit 455c46616277d33ec36fe87c770f4e705f0291cf
  5. Wouter Wolters commented on patch set 2 CR -2 02/19/16, 19:37

    first master + my comment still applies
  6. Wouter Wolters uploaded patch set 3 03/04/16, 17:43

  7. Wouter Wolters voted on patch set 3 CR +2 V +2 03/04/16, 17:43

  8. Gerrit merged patch set 3 03/04/16, 17:44