46461[BUGFIX] Off-by-one error in FAL's LocalDriver
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Benni Mack +2
- Daniel Goerz +1
- Roman Schürmann +1
- Mathias Schreiber +1
- Markus Sommer +1
- Markus Klein +1
- Frans Saris +1
- Michael Oehlhof +1
-
Verified V +2
- Andreas Kienast +2
- Benni Mack +2
- Daniel Goerz +1
- Mathias Schreiber +1
- Markus Sommer +1
- Michael Oehlhof +1
Issues 1
Files 1
Review log 15
-
Andreas Kienast uploaded patch set 1 02/03/16, 14:34
-
Markus Klein wrote 02/03/16, 14:40
Patch set 2: Commit message was updated. -
Markus Klein commented on patch set 2 02/03/16, 14:41
Shall we really change that for 6.2? If an ext already compensates for this off by one, this will break the ext now. Really a bad situation. -
Markus Klein voted on patch set 2 CR +1 02/03/16, 14:48
-
Andreas Kienast commented on patch set 2 02/03/16, 14:49
Reply
I've grepped our local TER mirror and didn't find any extension calling ``getFilesInFolder`` with ``$start`` being > 0. -
Mathias Schreiber voted on patch set 2 CR +1 V +1 02/04/16, 08:54
-
Roman Schürmann voted on patch set 2 CR +1 02/04/16, 09:02
-
Frans Saris voted on patch set 2 CR +1 02/04/16, 14:43
-
Daniel Goerz commented on patch set 2 CR +1 V +1 02/04/16, 15:02
Verified in master and 7.6 -
Michael Oehlhof voted on patch set 2 CR +1 V +1 02/04/16, 15:34
-
Markus Sommer voted on patch set 2 CR +1 V +1 02/05/16, 09:32
-
Benni Mack voted on patch set 2 CR +2 V +2 02/05/16, 15:51
-
Andreas Kienast voted on patch set 2 CR +2 V +2 02/05/16, 15:52
-
Gerrit merged patch set 2 02/05/16, 15:52
-
Andreas Kienast commented on patch set 3 02/05/16, 15:52
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 6b82dde4fbefc6f7688317b1cfdd0d2c18a7a1a3