Review main Abandoned

46482[BUGFIX] Use new content element wizard in frontend editing

Christian Weiske CR 0 V 0 Easy +31 −0 updated 11/29/17, 15:05

Commit message

When clicking the "New record after" button on content elements
in the frontend, the "New content element wizard" is shown instead
of the generic "create new record" popup.

This makes it easier for editors to select the content element type.

Since the FrontendEditPanel does not have all data required for the
NewContentElementController, that controller has been modified to
detect the correct parameters like page id and column position
automatically.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 2129

Show 4 earlier messages
  1. Christian Weiske uploaded patch set 1 02/04/16, 12:46

  2. Christian Weiske updated the commit message in patch set 2 02/04/16, 12:46

  3. Benni Mack commented on patch set 2 03/03/16, 15:09

    NewContentElementController.php:178

    any reason why we need this "public"?
  4. Christian Weiske uploaded patch set 3 03/07/16, 08:09

  1. Christian Weiske uploaded patch set 4 03/14/16, 12:11

  2. Sascha Egerer commented on patch set 4 CR -1 03/15/16, 07:31

    NewContentElementController.php:155

    Please use strict type comparison like !== and ===

    NewContentElementController.php:184

    please use (int) cast instead of intval()
  3. Christian Weiske uploaded patch set 5 03/15/16, 10:21

  4. Sascha Egerer commented on patch set 5 02/20/17, 20:25

    This one can be abondened, right?
  5. Georg Ringer commented on patch set 5 CR -1 02/21/17, 07:21

    NewContentElementController.php:603

    this class is deprecated, use doctrine!
  6. Christian Weiske uploaded patch set 6 02/21/17, 08:02

  7. Christian Weiske uploaded patch set 7 02/21/17, 08:03

  8. TYPO3com voted on patch set 6 V -1 02/21/17, 08:10 Completed build in 08m 33s on Tue, 21 Feb, 09:10 AM Test Summary: 56381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8327

  9. TYPO3com voted on patch set 7 V -1 02/21/17, 08:12 Completed build in 09m 13s on Tue, 21 Feb, 09:12 AM Test Summary: 56381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8328

  10. Christian Weiske uploaded patch set 8 02/21/17, 08:19

  11. TYPO3com voted on patch set 8 V -1 02/21/17, 08:26 Completed build in 06m 39s on Tue, 21 Feb, 09:26 AM Test Summary: 1 of 56381 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8329

  12. Christian Weiske rebased onto patch set 9 02/21/17, 08:33

  13. TYPO3com voted on patch set 9 V +1 02/21/17, 08:41 Completed build in 07m 13s on Tue, 21 Feb, 09:41 AM Test Summary: 56381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8330

  14. Christian Weiske rebased onto patch set 10 08/18/17, 07:35

  15. TYPO3com voted on patch set 10 V -1 08/18/17, 07:35 Completed build in 19s on Fri, 18 Aug, 09:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13796

  16. Benni Mack commented on patch set 10 08/23/17, 16:33

    hey, should we go witha bugfix instead? should go into 8.7 as well IMHO
  17. Benni Mack updated the commit message in patch set 11 11/28/17, 12:15

  18. TYPO3com voted on patch set 11 V -1 11/28/17, 12:15 Completed build in 08s on Tue, 28 Nov, 01:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16799

  19. Benni Mack uploaded patch set 12 11/28/17, 12:16

  20. TYPO3com voted on patch set 12 V -1 11/28/17, 12:27 Completed build in 11m 09s on Tue, 28 Nov, 01:27 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16800

  21. Christian Kuhn rebased onto patch set 13 11/28/17, 12:42

  22. TYPO3com voted on patch set 13 V +1 11/28/17, 12:56 Completed build in 13m 15s on Tue, 28 Nov, 01:56 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16812

  23. Susi Moog commented on patch set 13 V -1 11/29/17, 14:30

    This won't work anymore in this way, as the content element wizard is a modal that updates the underlying frame. The patch currently displays the content element wizard but you can't select anything.
  24. Susi Moog commented on patch set 13 11/29/17, 15:05

    I'll abandon the patch and close the ticket now, as there is no easy solution available and the whole structure would have to be reworked since the backend changes to the new content element wizard (modal view). As the new frontend editing is around the corner, I don't think it makes sense to spend energy on this one anymore. If you disagree, reopen the patch by pushing with a new concept.
  25. Susi Moog abandoned the change 11/29/17, 15:05