46482[BUGFIX] Use new content element wizard in frontend editing
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 2129
Show 4 earlier messages
-
Christian Weiske uploaded patch set 4 03/14/16, 12:11
-
Sascha Egerer commented on patch set 4 CR -1 03/15/16, 07:31
NewContentElementController.php:155Please use strict type comparison like !== and ===NewContentElementController.php:184please use (int) cast instead of intval() -
Christian Weiske uploaded patch set 5 03/15/16, 10:21
-
Sascha Egerer commented on patch set 5 02/20/17, 20:25
This one can be abondened, right? -
Georg Ringer commented on patch set 5 CR -1 02/21/17, 07:21
NewContentElementController.php:603this class is deprecated, use doctrine! -
Christian Weiske uploaded patch set 6 02/21/17, 08:02
-
Christian Weiske uploaded patch set 7 02/21/17, 08:03
-
TYPO3com voted on patch set 6 V -1 02/21/17, 08:10 Completed build in 08m 33s on Tue, 21 Feb, 09:10 AM Test Summary: 56381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8327
-
TYPO3com voted on patch set 7 V -1 02/21/17, 08:12 Completed build in 09m 13s on Tue, 21 Feb, 09:12 AM Test Summary: 56381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8328
-
Christian Weiske uploaded patch set 8 02/21/17, 08:19
-
TYPO3com voted on patch set 8 V -1 02/21/17, 08:26 Completed build in 06m 39s on Tue, 21 Feb, 09:26 AM Test Summary: 1 of 56381 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8329
-
Christian Weiske rebased onto patch set 9 02/21/17, 08:33
-
TYPO3com voted on patch set 9 V +1 02/21/17, 08:41 Completed build in 07m 13s on Tue, 21 Feb, 09:41 AM Test Summary: 56381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8330
-
Christian Weiske rebased onto patch set 10 08/18/17, 07:35
-
TYPO3com voted on patch set 10 V -1 08/18/17, 07:35 Completed build in 19s on Fri, 18 Aug, 09:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13796
-
Benni Mack commented on patch set 10 08/23/17, 16:33
hey, should we go witha bugfix instead? should go into 8.7 as well IMHO -
Benni Mack updated the commit message in patch set 11 11/28/17, 12:15
-
TYPO3com voted on patch set 11 V -1 11/28/17, 12:15 Completed build in 08s on Tue, 28 Nov, 01:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16799
-
Benni Mack uploaded patch set 12 11/28/17, 12:16
-
TYPO3com voted on patch set 12 V -1 11/28/17, 12:27 Completed build in 11m 09s on Tue, 28 Nov, 01:27 PM Test Summary: 6 of 57229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16800
-
Christian Kuhn rebased onto patch set 13 11/28/17, 12:42
-
TYPO3com voted on patch set 13 V +1 11/28/17, 12:56 Completed build in 13m 15s on Tue, 28 Nov, 01:56 PM Test Summary: 56870 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16812
-
Susi Moog commented on patch set 13 V -1 11/29/17, 14:30
This won't work anymore in this way, as the content element wizard is a modal that updates the underlying frame. The patch currently displays the content element wizard but you can't select anything. -
Susi Moog commented on patch set 13 11/29/17, 15:05
I'll abandon the patch and close the ticket now, as there is no easy solution available and the whole structure would have to be reworked since the backend changes to the new content element wizard (modal view). As the new frontend editing is around the corner, I don't think it makes sense to spend energy on this one anymore. If you disagree, reopen the patch by pushing with a new concept. -
Susi Moog abandoned the change 11/29/17, 15:05
NewContentElementController.php:178