Review main Merged

46496[BUGFIX] Correct layout and ensure HTML is rendered

Markus Sommer CR +2 V +2 Easy +3 −3 updated 10/17/16, 07:53

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Riccardo De Contardi +1

Issues 1

Files 3

Review log 10

  1. Markus Sommer uploaded patch set 1 02/05/16, 11:24

  2. Markus Sommer uploaded patch set 2 02/05/16, 11:35

  3. Mathias Brodala wrote 02/05/16, 11:43

    Patch set 3: Published edit on patch set 2.
  4. Wouter Wolters voted on patch set 3 CR +1 V +1 02/05/16, 20:00

  5. Riccardo De Contardi commented on patch set 3 V +1 02/05/16, 20:35

    It works, but IMO textareas with 1 or 2 rows are a bit difficult to read...
  6. Benni Mack voted on patch set 3 CR +2 V +2 02/05/16, 20:53

  7. Gerrit merged patch set 3 02/05/16, 20:53

  8. Helmut Hummel commented on patch set 4 10/17/16, 07:02

    StatusMessage.html:26

    Any particular reason for adding the format.raw here? It enables Cross-Site Scripting: https://review.typo3.org/#/c/50235/
  9. Helmut Hummel commented on patch set 4 10/17/16, 07:17

    StatusMessage.html:26 Reply

    ah, I think this was due to broken escaping behavior in Fluid back then
  10. Benni Mack commented on patch set 4 10/17/16, 07:53

    StatusMessage.html:26 Reply

    yeah, good point, let's see if we can find a better solution here.