Review TYPO3_7-6 Merged

46501[BUGFIX] Off-by-one error in FAL's LocalDriver

Andreas Kienast CR +2 V +2 Easy +0 −4 updated 02/05/16, 15:52

Commit message

Currently, the LocalDriver of FAL has an off-by-one issue. The passed
starting pointer gets decremented by one, causing issues in the file list
while browsing.

The pointer decrement is removed with this change.

The whole core does not call ``ResourceStorage->getFilesInFolder()``
with the parameters``$start`` and ``$maxNumberOfItems`` having
another value than 0, so this change is assumed to be safe.

Review

  • Code review CR +2
    • Andreas Kienast +2
  • Verified V +2
    • Andreas Kienast +2

Issues 1

Files 1

Review log 3

  1. Andreas Kienast commented on patch set 1 02/05/16, 15:52

    Cherry Picked from branch master.
  2. Andreas Kienast voted on patch set 1 CR +2 V +2 02/05/16, 15:52

  3. Gerrit merged patch set 1 02/05/16, 15:52