Review main Merged Breaking

46505[!!!][TASK] Update Symfony Console to version 3.x

Mathias Brodala CR +2 V +2 Hard +204 −61 updated 02/29/16, 10:15

Commit message

This migrates the Extbase ConsoleOutput wrapper to the newer API.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
    • Frank Nägler +1
  • Verified V +2
    • Benni Mack +2
    • Frank Nägler +1

Issues 1

Files 4

Review log 27

Show 2 earlier messages
  1. Mathias Brodala uploaded patch set 1 02/05/16, 16:43

  2. Mathias Brodala uploaded patch set 2 02/05/16, 16:54

  1. Mathias Brodala uploaded patch set 3 02/05/16, 17:23

  2. Mathias Brodala uploaded patch set 4 02/05/16, 17:37

  3. Mathias Brodala commented on patch set 4 02/05/16, 17:38

    Removed undefined default values for hidden questions.
  4. Wouter Wolters voted on patch set 4 CR +1 02/05/16, 19:54

  5. Mathias Brodala uploaded patch set 5 02/08/16, 08:40

  6. Mathias Brodala commented on patch set 5 02/08/16, 08:40

    Rebased to master.
  7. Mathias Brodala uploaded patch set 6 02/08/16, 09:16

  8. Mathias Brodala commented on patch set 6 02/08/16, 09:17

    Rebased to master.
  9. Frank Nägler voted on patch set 6 CR +1 02/08/16, 09:54

  10. Frank Nägler commented on patch set 6 V +1 02/08/16, 10:01

    looks good to me
  11. Daniel Goerz voted on patch set 6 CR +1 02/10/16, 22:37

  12. Benni Mack voted on patch set 6 CR +2 V +2 02/12/16, 06:26

  13. Gerrit merged patch set 6 02/12/16, 06:26

  14. Nicole Hummel commented on patch set 7 02/16/16, 23:07

    What is the benefit of this and the other patches as new functionality is used from the new version? This makes it harder for extension developers to maintain their versions for different TYPO3 versions. IMHO as long as we don't use new functions there is no need to update to new dependencies
  15. Benni Mack commented on patch set 7 02/16/16, 23:11

    Hey Nicole. Basically, we try to ensure that we keep up with the release cycles with symfony: - TYPO3 v7 should be bound to a Symfony LTS version (it is - with 2.7) - TYPO3 v8 LTS should be bound to a Symfony LTS version (we now have 3.0, but 3.4 would be the next LTS, which will only be released in Sep 2017 - AFTER our release). See http://symfony.com/doc/current/contributing/community/releases.html So, yeah. I think 2.8 would be more appropriate then for v8 - do you agree?
  16. Nicole Hummel commented on patch set 7 02/16/16, 23:24

    If I got it right, you tend to downgrade to version 2.8 which I would appreciate for extension developer.
  17. Frank Nägler commented on patch set 7 02/16/16, 23:33

    Since we are on 3.0 it is possible to install TYPO3 as content manager in a laravel project. If we downgrade, laravel 5 and TYPO3 can not be used in combination because of symfony/console conflict.
  18. Helmut Hummel commented on patch set 7 02/17/16, 00:00

    well, there are projects that require symfony packages <3.0, these currently won't work with TYPO3 CMS why are we enforcing 3.0 anyway? ">=2.8|<3.1" would make it possible to use one or the other type of package
  19. Benni Mack commented on patch set 7 02/17/16, 00:01

    even better @helhum
  20. Mathias Brodala commented on patch set 7 02/17/16, 08:35

    Just had a look and 2.8 does indeed look fine since it provides both the old and the new helper classes. > ">=2.8|<3.1" would make it possible to use one or the other type of > package Any reason for the restriction to < 3.1?
  21. Frank Nägler commented on patch set 7 02/17/16, 08:41

    >=2.8|<3.1 sounds good, if I understand it correctly, this means, TYPO3 will work with 2.8 and 3.0 so the conflict I mentioned above will not happen again? So if TYPO3 is compatible with this version range, I am fine.
  22. Nicole Hummel commented on patch set 7 02/17/16, 10:05

  23. Nicole Hummel commented on patch set 7 02/27/16, 11:48

    Post -1

    ConsoleOutput.php:37

    This breaks executing commands as scheduler task with PHP Warning: array_shift() expects parameter 1 to be array, null given in vendor\symfony\console\Input\ArgvInput.php line 59
  24. Nicole Hummel commented on patch set 7 02/27/16, 11:54

    ConsoleOutput.php:37 Reply

    Sorry, "$this->input = new ArgvInput();" in constructor throws th warning
  25. Mathias Brodala commented on patch set 7 02/29/16, 10:15

    ConsoleOutput.php:37 Reply

    Do you mean when executing in BE context? In CLI context $_SERVER['argv'] should exist.