46506[BUGFIX] FrontendContentAdapterService replaces LF chars before concat
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Daniel Gohlke +1
- Marco Bresch +1
-
Verified V +2
- Anja Leichsenring +2
- Daniel Gohlke +1
- Marco Bresch +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1620
-
Daniel Neugebauer uploaded patch set 1 02/05/16, 17:17
-
Nicole Hummel commented on patch set 1 CR -1 04/21/16, 11:52
Missing unit tests for the bugfix -
Daniel Neugebauer uploaded patch set 2 05/23/16, 15:32
-
Daniel Neugebauer commented on patch set 2 05/23/16, 15:35
Sorry, didn't notice this class is covered. Added the unit test; written for 6.2 head where it fails, succeeding with this patch. -
Anja Leichsenring rebased onto patch set 3 10/27/16, 09:17
-
TYPO3com voted on patch set 3 V +1 10/27/16, 09:25 Completed build in 08m 17s on Thu, 27 Oct, 11:25 AM Test Summary: 30696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-23
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 10/27/16, 09:26
-
Andreas Kienast commented on patch set 3 CR -1 10/27/16, 09:32
Can’t we use the constants LF, CR and CRLF as defined in SystemEnvironmentBuilder? -
Anja Leichsenring commented on patch set 3 CR -1 10/27/16, 09:38
on it -
Anja Leichsenring uploaded patch set 4 10/27/16, 09:42
-
TYPO3com voted on patch set 4 V +1 10/27/16, 09:50 Completed build in 08m 27s on Thu, 27 Oct, 11:50 AM Test Summary: 30696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-24
-
Anja Leichsenring voted on patch set 4 CR +1 V +1 10/27/16, 09:54
-
Daniel Gohlke voted on patch set 4 CR +1 V +1 10/27/16, 10:32
-
Marco Bresch commented on patch set 5 10/27/16, 10:36
Published edit on patch set 4. -
Marco Bresch voted on patch set 5 CR +1 V +1 10/27/16, 10:37
-
Daniel Gohlke voted on patch set 5 CR +1 V +1 10/27/16, 10:39
-
TYPO3com voted on patch set 5 V -1 10/27/16, 10:41 Completed build in 04m 05s on Thu, 27 Oct, 12:41 PM Test Summary: 30696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-25
-
TYPO3com voted on patch set 5 V +1 10/27/16, 10:46 Completed build in 13m 59s on Thu, 27 Oct, 12:46 PM Test Summary: 30696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-25
-
Anja Leichsenring voted on patch set 5 CR +2 V +2 10/27/16, 10:47
-
Gerrit merged patch set 5 10/27/16, 10:48