Review TYPO3_6-2 Merged

46506[BUGFIX] FrontendContentAdapterService replaces LF chars before concat

Daniel Neugebauer CR +2 V +2 Normal +94 −2 updated 10/27/16, 10:48

Commit message

FrontendContentAdapterService now replaces LF characters before
concatenation is being performed with LF.

CRLF is being treated first to avoid causing duplicate line-breaks.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Daniel Gohlke +1
    • Marco Bresch +1
  • Verified V +2
    • Anja Leichsenring +2
    • Daniel Gohlke +1
    • Marco Bresch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1620

  1. Daniel Neugebauer uploaded patch set 1 02/05/16, 17:17

  2. Nicole Hummel commented on patch set 1 CR -1 04/21/16, 11:52

    Missing unit tests for the bugfix
  3. Daniel Neugebauer uploaded patch set 2 05/23/16, 15:32

  4. Daniel Neugebauer commented on patch set 2 05/23/16, 15:35

    Sorry, didn't notice this class is covered. Added the unit test; written for 6.2 head where it fails, succeeding with this patch.
  5. Anja Leichsenring rebased onto patch set 3 10/27/16, 09:17

  6. TYPO3com voted on patch set 3 V +1 10/27/16, 09:25 Completed build in 08m 17s on Thu, 27 Oct, 11:25 AM Test Summary: 30696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-23

  7. Anja Leichsenring voted on patch set 3 CR +1 V +1 10/27/16, 09:26

  8. Andreas Kienast commented on patch set 3 CR -1 10/27/16, 09:32

    Can’t we use the constants LF, CR and CRLF as defined in SystemEnvironmentBuilder?
  9. Anja Leichsenring commented on patch set 3 CR -1 10/27/16, 09:38

    on it
  10. Anja Leichsenring uploaded patch set 4 10/27/16, 09:42

  11. TYPO3com voted on patch set 4 V +1 10/27/16, 09:50 Completed build in 08m 27s on Thu, 27 Oct, 11:50 AM Test Summary: 30696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-24

  12. Anja Leichsenring voted on patch set 4 CR +1 V +1 10/27/16, 09:54

  13. Daniel Gohlke voted on patch set 4 CR +1 V +1 10/27/16, 10:32

  14. Marco Bresch commented on patch set 5 10/27/16, 10:36

    Published edit on patch set 4.
  15. Marco Bresch voted on patch set 5 CR +1 V +1 10/27/16, 10:37

  16. Daniel Gohlke voted on patch set 5 CR +1 V +1 10/27/16, 10:39

  17. TYPO3com voted on patch set 5 V -1 10/27/16, 10:41 Completed build in 04m 05s on Thu, 27 Oct, 12:41 PM Test Summary: 30696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-25

  18. TYPO3com voted on patch set 5 V +1 10/27/16, 10:46 Completed build in 13m 59s on Thu, 27 Oct, 12:46 PM Test Summary: 30696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-25

  19. Anja Leichsenring voted on patch set 5 CR +2 V +2 10/27/16, 10:47

  20. Gerrit merged patch set 5 10/27/16, 10:48