Review main Merged

4651[BUGFIX] Externally-referenced ll-XML files are not parsed

Xavier Perseguers CR +2 V +2 Easy +8 −0 updated 06/03/13, 20:49

Commit message

It is not possible to load an externally-referenced localization file
as explained in the documentation:

<languageKey index="fr">EXT:yourext/path/to/fr.locallang.xml</languageKey>

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Dominique Feyer +1
  • Verified V +2
    • Xavier Perseguers +2
    • Dominique Feyer +1

Files 1

Review log 10

  1. Andreas Kießling commented on patch set 1 08/30/11, 08:34

    (1 inline comment) The implementation in t3lib_div::readLLXMLfile <= 4.5 is not limited to paths for extensions. locallang.xml files may also be used in fileadmin dir, for e.g. extensions like formhandler that utilize LLL markers in their templates. Did you test such a usecase?
  2. Xavier Perseguers commented on patch set 1 08/30/11, 08:34

    Do not submit

    class.t3lib_l10n_parser_llxml.php:112

    This has to be further adjusted because the root element of such files is not <T3locallang> but <T3locallangExt> according to the documentation: http://typo3.org/documentation/document-library/core-documentation/doc_core_api/4.1.0/view/7/2/

    class.t3lib_l10n_parser_llxml.php:112 Reply

    Done
  3. Xavier Perseguers commented on patch set 1 1 comment 08/30/11, 08:34

    No score Tested, it works as expected
  4. Xavier Perseguers commented on patch set 2 08/30/11, 08:34

    FYI, this will be merged automatically tomorrow morning if it is not reviewed until then (nobrainer).
  5. Xavier Perseguers uploaded patch set 2 08/30/11, 08:34

  6. Xavier Perseguers commented on patch set 2 V 0 08/30/11, 08:34

    by team member; Looks good to me, approved
  7. Dominique Feyer commented on patch set 2 08/30/11, 08:34

    Verified; Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 08/30/11, 08:34

  9. Mr. Jenkins commented on patch set 2 08/30/11, 08:34

  10. Xavier Perseguers merged patch set 2 08/30/11, 08:34