Review main Merged Breaking

46520[!!!][TASK] Make TimeTracker a singleton

Georg Ringer CR +2 V +2 Normal +135 −74 updated 02/21/16, 11:41

Commit message

By declaring the TimeTracker class as singleton, there is no
need anymore for $GLOBALS['TT'].

Review

  • Code review CR +2
    • Susi Moog +2
    • Daniel Goerz +1
    • Michiel Roos +1
  • Verified V +2
    • Susi Moog +2
    • Daniel Goerz +1
    • Michiel Roos +1

Issues 1

Files 27

Show 7 more files

Review log 20

  1. Georg Ringer uploaded patch set 1 02/08/16, 10:06

  2. Georg Ringer uploaded patch set 2 02/09/16, 07:18

  3. Georg Ringer uploaded patch set 3 02/15/16, 07:22

  4. Georg Ringer uploaded patch set 4 02/16/16, 18:48

  5. Wouter Wolters commented on patch set 4 02/16/16, 19:03

    probably a copy and paste mistake :)

    SearchFormController.php:546

    one space too much

    SearchFormController.php:552

    one space too much

    SearchFormController.php:650

    one space too much

    SearchFormController.php:652

    one space too much

    SearchFormController.php:692

    one space too much

    SearchFormController.php:822

    one space too much

    SearchFormController.php:885

    one space too much
  6. Benni Mack wrote 02/18/16, 22:33

    Patch set 5: Published edit on patch set 4.
  7. Benni Mack voted on patch set 5 CR +1 02/18/16, 22:35

  8. Daniel Goerz commented on patch set 5 V -1 02/19/16, 17:40

    Indexer.php:2096

    On every frontend request: Fatal error: Call to a member function push() on a non-object
  9. Michiel Roos rebased onto patch set 6 02/20/16, 07:52

  10. Michiel Roos uploaded patch set 7 02/20/16, 07:57

  11. Michiel Roos voted on patch set 7 CR +1 V +1 02/20/16, 08:14

  12. Daniel Goerz uploaded patch set 8 02/20/16, 09:16

  13. Daniel Goerz voted on patch set 8 CR +1 V +1 02/20/16, 09:18

  14. Michiel Roos uploaded patch set 9 02/20/16, 12:27

  15. Daniel Goerz commented on patch set 9 CR -1 02/20/16, 12:30

    Why did you revert my changes?
  16. Michiel Roos uploaded patch set 10 02/20/16, 13:04

  17. Michiel Roos commented on patch set 10 CR +1 V +1 02/20/16, 13:04

    > Why did you revert my changes? Sorry Just wanted to add a var annotation to AbstractService
  18. Daniel Goerz commented on patch set 10 CR +1 V +1 02/20/16, 13:15

    np
  19. Susi Moog voted on patch set 10 CR +2 V +2 02/21/16, 11:40

  20. Gerrit merged patch set 10 02/21/16, 11:41