46520[!!!][TASK] Make TimeTracker a singleton
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Daniel Goerz +1
- Michiel Roos +1
-
Verified V +2
- Susi Moog +2
- Daniel Goerz +1
- Michiel Roos +1
Issues 1
Files 27
- typo3/sysext/core/Classes/Database/DatabaseConnection.php+5 −2
- typo3/sysext/core/Classes/Error/ErrorHandler.php+3 −2
- typo3/sysext/core/Classes/Service/AbstractService.php+11 −9
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php+2 −1
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+2 −2
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Breaking-73504-MakeTimeTrackerASingleton.rstnew+26 −0
- typo3/sysext/frontend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php+3 −2
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectArrayContentObject.php+2 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectArrayInternalContentObject.php+2 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+3 −2
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+3 −4
- typo3/sysext/frontend/Classes/ContentObject/UserContentObject.php+4 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+3 −2
- typo3/sysext/frontend/Classes/Http/EidRequestHandler.php+4 −2
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+2 −6
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+2 −2
- typo3/sysext/frontend/Classes/View/AdminPanelView.php+3 −2
Show 7 more files
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+0 −1
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchFormController.php7+15 −8
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+3 −2
- typo3/sysext/indexed_search/Classes/Indexer.php1+17 −9
- typo3/sysext/indexed_search_mysql/Classes/Hook/MysqlFulltextIndexHook.php+6 −2
- typo3/sysext/saltedpasswords/Classes/SaltedPasswordService.php+10 −6
Review log 20
-
Georg Ringer uploaded patch set 1 02/08/16, 10:06
-
Georg Ringer uploaded patch set 2 02/09/16, 07:18
-
Georg Ringer uploaded patch set 3 02/15/16, 07:22
-
Georg Ringer uploaded patch set 4 02/16/16, 18:48
-
Wouter Wolters commented on patch set 4 02/16/16, 19:03
probably a copy and paste mistake :)SearchFormController.php:546one space too muchSearchFormController.php:552one space too muchSearchFormController.php:650one space too muchSearchFormController.php:652one space too muchSearchFormController.php:692one space too muchSearchFormController.php:822one space too muchSearchFormController.php:885one space too much -
Benni Mack wrote 02/18/16, 22:33
Patch set 5: Published edit on patch set 4. -
Benni Mack voted on patch set 5 CR +1 02/18/16, 22:35
-
Daniel Goerz commented on patch set 5 V -1 02/19/16, 17:40
Indexer.php:2096On every frontend request: Fatal error: Call to a member function push() on a non-object -
Michiel Roos rebased onto patch set 6 02/20/16, 07:52
-
Michiel Roos uploaded patch set 7 02/20/16, 07:57
-
Michiel Roos voted on patch set 7 CR +1 V +1 02/20/16, 08:14
-
Daniel Goerz uploaded patch set 8 02/20/16, 09:16
-
Daniel Goerz voted on patch set 8 CR +1 V +1 02/20/16, 09:18
-
Michiel Roos uploaded patch set 9 02/20/16, 12:27
-
Daniel Goerz commented on patch set 9 CR -1 02/20/16, 12:30
Why did you revert my changes? -
Michiel Roos uploaded patch set 10 02/20/16, 13:04
-
Michiel Roos commented on patch set 10 CR +1 V +1 02/20/16, 13:04
> Why did you revert my changes? Sorry Just wanted to add a var annotation to AbstractService -
Daniel Goerz commented on patch set 10 CR +1 V +1 02/20/16, 13:15
np -
Susi Moog voted on patch set 10 CR +2 V +2 02/21/16, 11:40
-
Gerrit merged patch set 10 02/21/16, 11:41