Review main Merged

46545[TASK] Use UTF-8 as default for LanguageService

Benni Mack CR +2 V +2 Normal +25 −31 updated 02/12/16, 08:00

Commit message

The TYPO3 Backend is utf-8 by default since TYPO3 4.5, but certain
places read the value still from $GLOBALS['LANG']->charSet, which
is now always "utf-8".

All occurrences are replaced by "utf-8" for now. Future cleanups
will further simplify these code changes.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Wouter Wolters +1
  • Verified V +2
    • Morton Jonuschat +2
    • Wouter Wolters +1

Issues 1

Files 14

Review log 6

  1. Benni Mack uploaded patch set 1 02/09/16, 11:08

  2. Wouter Wolters voted on patch set 1 CR +1 V +1 02/11/16, 22:23

  3. Oliver Klee commented on patch set 1 02/11/16, 23:32

    LanguageService.php:46

    Should we mark it as @deprecated so that IDEs like PhpStorm can complain when someone uses it?
  4. Benni Mack commented on patch set 1 02/12/16, 06:23

    LanguageService.php:46 Reply

    There will be some more cleanups, where I will then also deprecate this option as well at a later point, OK?
  5. Morton Jonuschat voted on patch set 1 CR +2 V +2 02/12/16, 08:00

  6. Gerrit merged patch set 1 02/12/16, 08:00