Review TYPO3_6-2 Merged

46598[BUGFIX] Do not fetch pages with pid < 0 in prepareCacheFlush

Steffen Göde CR +2 V +2 Easy +5 −3 updated 12/08/16, 21:27

Commit message

Do not fetch workspace related pages to prepare cache flushing.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Steffen Göde uploaded patch set 1 02/11/16, 15:24

  2. Steffen Göde updated the commit message in patch set 2 02/12/16, 09:10

  3. Steffen Göde updated the commit message in patch set 3 02/12/16, 09:14

  4. Oliver Hader commented on patch set 3 CR -1 12/07/16, 14:25

    Thanks for your patch. By looking into the code, it seems that the first query is sufficient already, thus the two later query adjustments are not required anymore. Besides that, please consider checking this issue in the Git master branch and a patch there first. Thx!

    DataHandler.php:7301

    A.pid >= 0 since pages could be on the root-level

    DataHandler.php:7308

    Not required anymore, since the first query retrieves only UIDs of non-workspace records

    DataHandler.php:7320

    Not required anymore, since the first query retrieves only PIDs of non-workspace records
  5. Oliver Hader commented on patch set 3 12/08/16, 20:12

    Waiting for the master backport to 6.2. The impact for 6.2 is IMO high enough, thus fine to backport it...
  6. Wouter Wolters uploaded patch set 4 12/08/16, 20:34

  7. Susi Moog voted on patch set 4 CR +1 V +1 12/08/16, 20:35

  8. TYPO3com voted on patch set 4 V +1 12/08/16, 20:42 Completed build in 07m 56s on Thu, 8 Dec, 09:42 PM Test Summary: 30884 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-71

  9. Wouter Wolters commented on patch set 5 12/08/16, 21:22

    Published edit on patch set 4.
  10. Oliver Hader voted on patch set 5 CR +1 12/08/16, 21:23

  11. TYPO3com voted on patch set 5 V +1 12/08/16, 21:26 Completed build in 04m 11s on Thu, 8 Dec, 10:26 PM Test Summary: 30884 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-72

  12. Oliver Hader voted on patch set 5 V +1 12/08/16, 21:27

  13. Oliver Hader voted on patch set 5 CR +2 V +2 12/08/16, 21:27

  14. Gerrit merged patch set 5 12/08/16, 21:27