Review main Abandoned

46618[BUGFIX] Restore functionality for extbase template configuration

Benjamin Serfhos CR 0 V 0 Easy +36 −0 updated 04/07/16, 11:14

Commit message

BackendTemplateView is missing default view configiration settings.
\TYPO3\CMS\Extbase\Mvc\Controller\ActionController should be able
to set root paths via typoscript

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 8

  1. Benjamin Serfhos uploaded patch set 1 02/12/16, 14:08

  2. Mathias Schreiber commented on patch set 1 02/12/16, 15:27

    I will refrain from a -2 for the time being but please consider the comment of the class: "Should be used as view if you want to use Fluid templates in a backend module in order to have a consistent backend." Changing the paths would result in the opposite. Every module could look different. We should discuss the usecase on Slack if possible (I'll be out until saturday though)
  3. Benni Mack commented on patch set 1 04/01/16, 13:17

    Hey Benjamin, this does not sound reasonable for me. a) How would you combine the BackendTemplateView (which is IMHO for non-extbase routes) with the ActionController? b) Isn't the default layout for the backend sufficient for the regular view? I'm super-unexcited introducing even more TypoScript (which was actually for the frontend in the original mind) for the backend.
  4. Benjamin Serfhos updated the commit message in patch set 2 04/01/16, 15:03

  5. Wouter Wolters commented on patch set 2 CR -1 04/05/16, 18:26

    I agree with Benni here. This BackendTemplateView is not meant to be used this way. The reason this template is there to keep a consitent backend UI. This bloats the backend even more with several options you can set.
  6. Benjamin Serfhos commented on patch set 2 04/05/16, 18:39

    Let's abandon this review then. I keep defending this change and only got valid responses with no real decisions.
  7. Christian Kuhn commented on patch set 2 04/07/16, 11:14

    ok, so let us abandon this one.
  8. Christian Kuhn abandoned the change 04/07/16, 11:14