Review main Merged

46626[TASK] Stick psr/log version to 1.0.0 in composer.json

Frank Nägler CR +2 V +2 Easy +11 −21 updated 11/04/16, 18:42

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1

Issues 1

Files 2

Review log 15

  1. Frank Nägler uploaded patch set 1 02/12/16, 17:09

  2. Mathias Brodala commented on patch set 1 02/12/16, 17:12

    Why?
  3. Christian Kuhn commented on patch set 1 CR +1 V +1 02/12/16, 17:13

    we shouldn't rely on @dev, but use released versions.
  4. Mathias Brodala commented on patch set 1 CR -1 02/12/16, 17:18

    Please use ^1.0.0 in this case.
  5. Benni Mack commented on patch set 1 CR -1 02/12/16, 17:19

    I wouldn't stick it to 1.0.0 but to a commit actually, see https://github.com/php-fig/log/commits/master
  6. Christian Kuhn commented on patch set 1 02/12/16, 17:23

    as far as i can see, the patches between master & 1.0.0 are mostly of cosmetically nature, no functional change. i think we could stick with 1.0.0.
  7. Benni Mack voted on patch set 1 CR +1 V +1 02/12/16, 17:23

  8. Benni Mack commented on patch set 1 02/12/16, 17:26

    well. In this very case I would stick to the hard dependency - 1.0.0 - it's a bunch of interfaces. In every other library I would use the ^1.0
  9. Frank Nägler commented on patch set 1 02/12/16, 17:28

    agree Benni, this was my intention with this version contraint
  10. Mathias Brodala commented on patch set 1 CR 0 02/15/16, 08:17

    I'm fine with the version constraint like this since I minor/bugfix releases are not to be expected for this kind of package.
  11. Christian Kuhn uploaded patch set 2 02/15/16, 09:17

  12. Christian Kuhn commented on patch set 2 CR +2 V +2 02/15/16, 09:23

    just rebased.
  13. Frank Nägler voted on patch set 2 CR +1 V +1 02/15/16, 09:23

  14. Gerrit merged patch set 2 02/15/16, 09:23

  15. Helmut Hummel commented on patch set 3 11/04/16, 18:42

    For the records: Setting hard dependencies like that, means that TYPO3 is not installable with other libraries that require at least 1.0.1 of psr/log (like monolog/monolog newest version) Good this has now changed in current master