Review main Merged

46627[TASK] Replace csConvObj calls

Benni Mack CR +2 V +2 Normal +103 −82 updated 02/16/16, 09:43

Commit message

The CharsetConverter object is agnostic
of charset and environment, and a singleton on top.

There are still several calls in the TYPO3 core
that tries to fetch csConv from TSFE or LANG
which relies heavily on the environment.

The calls are replaced with simple instance
calls where possible.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Froemken +1
  • Verified V +2
    • Georg Ringer +2
    • Stefan Froemken +1

Issues 1

Files 12

Review log 10

  1. Benni Mack uploaded patch set 1 02/12/16, 17:10

  2. Benni Mack uploaded patch set 2 02/15/16, 16:40

  3. Georg Ringer voted on patch set 2 CR +1 V +1 02/16/16, 08:40

  4. Stefan Froemken commented on patch set 2 V -1 02/16/16, 09:33

    BasicFileUtility.php:382

    You have changed the parameters of a public core method. Doesn't we need a breaking change document for that case?

    LocalizationUtility.php:249

    I think you can remove the complete if condition
  5. Benni Mack commented on patch set 2 02/16/16, 09:35

    See https://review.typo3.org/#/c/45695/ where we are going to remove the whole method anyway ;) So double RSTs does not make sense... The other remark in LocalizationUtility I will fix right away.
  6. Wouter Wolters commented on patch set 2 02/16/16, 09:35

    BasicFileUtility.php:382 Reply

    No, this is the last parameter, if you call this function with this parameter it still works and ignores the second parameter.

    LocalizationUtility.php:249 Reply

    +1
  7. Benni Mack wrote 02/16/16, 09:36

    Patch set 3: Published edit on patch set 2.
  8. Stefan Froemken voted on patch set 3 CR +1 V +1 02/16/16, 09:41

  9. Georg Ringer voted on patch set 3 CR +2 V +2 02/16/16, 09:43

  10. Gerrit merged patch set 3 02/16/16, 09:43