46627[TASK] Replace csConvObj calls
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Stefan Froemken +1
-
Verified V +2
- Georg Ringer +2
- Stefan Froemken +1
Issues 1
Files 12
- typo3/sysext/backend/Classes/Controller/LoginController.php+4 −1
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php+5 −3
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php+5 −3
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+10 −3
- typo3/sysext/core/Classes/Utility/File/BasicFileUtility.php2+10 −22
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+7 −8
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php2+4 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php+1 −5
- typo3/sysext/form/Classes/Domain/Filter/AbstractFilter.php+4 −2
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+20 −13
- typo3/sysext/indexed_search/Classes/Controller/SearchFormController.php+20 −13
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php+13 −4
Review log 10
-
Benni Mack uploaded patch set 1 02/12/16, 17:10
-
Benni Mack uploaded patch set 2 02/15/16, 16:40
-
Georg Ringer voted on patch set 2 CR +1 V +1 02/16/16, 08:40
-
Stefan Froemken commented on patch set 2 V -1 02/16/16, 09:33
LocalizationUtility.php:249I think you can remove the complete if condition -
Benni Mack commented on patch set 2 02/16/16, 09:35
See https://review.typo3.org/#/c/45695/ where we are going to remove the whole method anyway ;) So double RSTs does not make sense... The other remark in LocalizationUtility I will fix right away. -
Wouter Wolters commented on patch set 2 02/16/16, 09:35
BasicFileUtility.php:382ReplyNo, this is the last parameter, if you call this function with this parameter it still works and ignores the second parameter.LocalizationUtility.php:249Reply+1 -
Benni Mack wrote 02/16/16, 09:36
Patch set 3: Published edit on patch set 2. -
Stefan Froemken voted on patch set 3 CR +1 V +1 02/16/16, 09:41
-
Georg Ringer voted on patch set 3 CR +2 V +2 02/16/16, 09:43
-
Gerrit merged patch set 3 02/16/16, 09:43
BasicFileUtility.php:382