Review main Merged

46651[FEATURE] Add wizard component

Andreas Kienast CR +2 V +2 Hard +571 −208 updated 02/19/16, 18:08

Commit message

This patch adds a wizard component. The component allows
to add "slides" combined with a callback.

The localization wizard used in the Page module is converted
to the module wizard.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1

Issues 1

Files 6

Review log 18

  1. Andreas Kienast uploaded patch set 1 02/14/16, 16:21

  2. Andreas Kienast uploaded patch set 2 02/15/16, 09:10

  3. Andreas Kienast wrote 02/15/16, 09:10

    Patch set 3: Commit message was updated.
  4. Frank Nägler commented on patch set 3 CR -1 02/15/16, 12:29

    on it

    Wizard.js:43

    comment missing, please add also the @exports annotation
  5. Frank Nägler uploaded patch set 4 02/15/16, 12:40

  6. Andreas Kienast uploaded patch set 5 02/15/16, 14:15

  7. Andreas Kienast commented on patch set 5 CR -2 02/17/16, 07:30

  8. Andreas Kienast uploaded patch set 6 02/17/16, 16:20

  9. Andreas Kienast uploaded patch set 7 02/17/16, 16:22

  10. Andreas Kienast voted on patch set 7 CR 0 02/17/16, 16:22

  11. Andreas Kienast uploaded patch set 8 02/17/16, 18:40

  12. Andreas Kienast uploaded patch set 9 02/19/16, 13:32

  13. Andreas Kienast uploaded patch set 10 02/19/16, 15:13

  14. Frank Nägler commented on patch set 10 V -1 02/19/16, 17:41

    JS error: Uncaught TypeError: Cannot read property 'parent' of nullWizard.getComponent @ Wizard.js?bust=1455903583:309(anonymous function) @ Localization.js?bust=1455903583:178jQuery.event.dispatch @ jquery-2.1.4.js:4435elemData.handle @ jquery-2.1.4.js:4121
  15. Frank Nägler commented on patch set 10 CR +1 V +1 02/19/16, 17:44

    all fine, f.... browser cache again ;)
  16. Christian Kuhn commented on patch set 10 02/19/16, 17:58

    Feature-73429-WizardComponentHasBeenAdded.rst:2

    great .rst file!
  17. Christian Kuhn voted on patch set 10 CR +2 V +2 02/19/16, 18:08

  18. Gerrit merged patch set 10 02/19/16, 18:08