Review main Merged

46678[TASK] Move Modal.getSeverityClass to Severity module

Andreas Kienast CR +2 V +2 Normal +64 −25 updated 02/17/16, 16:03

Commit message

The method ``Modal.getSeverityClass`` is moved to the severity
module. The new method is called `Severity.getCssClass`.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 5

Review log 15

  1. Andreas Kienast uploaded patch set 1 02/15/16, 17:23

  2. Markus Klein wrote 02/15/16, 17:24

    Patch set 2: Commit message was updated.
  3. Markus Klein commented on patch set 2 02/15/16, 17:26

    Severity.js:58

    jsdoc?
  4. Andreas Kienast uploaded patch set 3 02/15/16, 17:41

  5. Andreas Kienast commented on patch set 3 CR -2 02/16/16, 09:37

  6. Andreas Kienast uploaded patch set 4 02/16/16, 09:50

  7. Andreas Kienast voted on patch set 4 CR 0 02/16/16, 09:50

  8. Andreas Kienast wrote 02/16/16, 09:50

    Patch set 5: Commit message was updated.
  9. Wouter Wolters commented on patch set 5 CR -1 02/16/16, 23:03

    Modal.js:191

    remove :)

    Severity.js:83

    no break needed anymore in default right?
  10. Andreas Kienast commented on patch set 5 02/17/16, 07:14

    Modal.js:191 Reply

    oops
  11. Andreas Kienast uploaded patch set 6 02/17/16, 07:16

  12. Andreas Kienast wrote 02/17/16, 07:18

    Patch set 7: Published edit on patch set 6.
  13. Wouter Wolters voted on patch set 7 CR +1 V +1 02/17/16, 07:54

  14. Christian Kuhn voted on patch set 7 CR +2 V +2 02/17/16, 16:03

  15. Gerrit merged patch set 7 02/17/16, 16:03