46679[TASK] Add UpdateWizard for RTE to always add P-tags
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 3435
Show 10 earlier messages
-
Benni Mack uploaded patch set 1 02/15/16, 17:25
-
Phat Hoang rebased onto patch set 2 04/12/16, 09:53
-
Phat Hoang uploaded patch set 3 04/14/16, 10:38
-
Phat Hoang uploaded patch set 4 04/14/16, 15:49
-
Phat Hoang uploaded patch set 5 04/14/16, 16:02
-
Phat Hoang commented on patch set 5 04/14/16, 16:05
Accidentally removed changes in typo3/sysext/core/Classes/Html/RteHtmlParser.php in previous patch so brought them back. -
Phat Hoang uploaded patch set 6 04/14/16, 19:37
-
Phat Hoang commented on patch set 6 04/14/16, 19:45
Removed '_all' from findAllRteFields and applied columnsOverrides to get the final fieldConfiguration RTE only possible in type 'flex' and 'text' Moved back from functional to unit test Added more tests (some are yet to be implemented) -
Phat Hoang uploaded patch set 7 04/15/16, 15:23
-
Phat Hoang uploaded patch set 8 04/15/16, 20:21
-
Phat Hoang commented on patch set 8 04/15/16, 20:28
Removed parsing of flexform xml in findAllRteFields, no need to deal with FILE:path/to/xml and sheets that point to other sheets. -
Phat Hoang uploaded patch set 9 04/15/16, 20:29
-
Phat Hoang commented on patch set 9 04/15/16, 20:29
Updated a comment -
Benni Mack uploaded patch set 10 04/20/16, 09:20
-
Jigal van Hemert uploaded patch set 11 05/01/16, 09:23
-
Jigal van Hemert uploaded patch set 12 05/01/16, 16:36
-
Nicole Hummel commented on patch set 12 CR -1 05/02/16, 13:04
I would prefer to mark the functions in RichTextFieldsUpdate as protected and use an accessible mock for testing or provide a mocked database connection with the strings to test.RichTextFieldsUpdate.php:23new lines?RichTextFieldsUpdate.php:54andRichTextFieldsUpdate.php:63!empty()RichTextFieldsUpdate.php:84empty($tcaFields) && is_array($tcaFields)RichTextFieldsUpdate.php:86I would prefer to use $this->markWizardAsDone()RichTextFieldsUpdate.php:91Would it be an option to set the in checkForUpdate() already?RichTextFieldsUpdate.php:99!empty($GLOBALS['TCA'][$table]['ctrl']['type']) to prevent wrong accessRichTextFieldsUpdate.php:108Should this be converted to doctrine?RichTextFieldsUpdate.php:127!empty()RichTextFieldsUpdate.php:130enable libxml_disable_entity_loader() before?RichTextFieldsUpdate.php:141!empty()RichTextFieldsUpdate.php:143IMHO this check should go into setParagraphTags()RichTextFieldsUpdate.php:152!empty()RichTextFieldsUpdate.php:152s.a.RichTextFieldsUpdate.php:163!empty()RichTextFieldsUpdate.php:164doctrine?RichTextFieldsUpdate.php:174s.a.RichTextFieldsUpdate.php:181superfluous spaceRichTextFieldsUpdate.php:187can be annotated in functionRichTextFieldsUpdate.php:246can be annotated in functionRichTextFieldsUpdate.php:257can be annotated in functionRichTextFieldsUpdate.php:274!empty()RichTextFieldsUpdate.php:280!empty()RichTextFieldsUpdate.php:295can be annotated in functionRichTextFieldsUpdateTest.php:30use statementRichTextFieldsUpdateTest.php:101any reason for splitting this? -
Oliver Hader commented on patch set 12 05/02/16, 16:05
RichTextFieldsUpdate.php:84Replyempty($tcaFields) should be enough thenRichTextFieldsUpdate.php:130ReplyYes -
Oliver Hader uploaded patch set 13 05/02/16, 17:24
-
Oliver Hader commented on patch set 12 05/02/16, 17:29
RichTextFieldsUpdate.php:23ReplyDoneRichTextFieldsUpdate.php:54ReplyDoneRichTextFieldsUpdate.php:63ReplyDoneRichTextFieldsUpdate.php:84ReplyI changed the order here a bit nowRichTextFieldsUpdate.php:86ReplyDoneRichTextFieldsUpdate.php:91ReplyI kept it here since the call is required anyway to get the remaining fieldsRichTextFieldsUpdate.php:99ReplyDoneRichTextFieldsUpdate.php:108ReplyProbably yes... I did not change that yetRichTextFieldsUpdate.php:127ReplyDoneRichTextFieldsUpdate.php:130ReplyDoneRichTextFieldsUpdate.php:141ReplyDoneRichTextFieldsUpdate.php:143ReplyStill @todoRichTextFieldsUpdate.php:152ReplyDoneRichTextFieldsUpdate.php:163ReplyDoneRichTextFieldsUpdate.php:174ReplyDoneRichTextFieldsUpdate.php:181ReplyDoneRichTextFieldsUpdate.php:187ReplyDoneRichTextFieldsUpdate.php:246ReplyDoneRichTextFieldsUpdate.php:257ReplyDoneRichTextFieldsUpdate.php:274ReplyDoneRichTextFieldsUpdate.php:280ReplyDoneRichTextFieldsUpdate.php:295ReplyDoneRichTextFieldsUpdateTest.php:20Changed that to UnitTest (which is the namespace and is sufficient as well)RichTextFieldsUpdateTest.php:30ReplyDoneRichTextFieldsUpdateTest.php:101ReplyObviously not, but I kept it... can be done in a separate clean up as well -
Oliver Hader commented on patch set 12 05/02/16, 17:31
@todo: * Change to use Doctrine calls * review again & test! -
Jigal van Hemert commented on patch set 12 05/02/16, 19:22
RichTextFieldsUpdate.php:108ReplyThe rest of the Install Tool doesn't use doctrine yet, that was the reason for using the "old" class for me.RichTextFieldsUpdateTest.php:362I'd like to add one with a section, but that can wait until later. -
Jigal van Hemert commented on patch set 13 CR +1 V +1 05/02/16, 19:25
Thanks Olly for taking care of the changes. I didn't have time today. Patch is still working fine! -
Oliver Hader commented on patch set 13 V -1 05/03/16, 08:52
Argument 1 passed to TYPO3\CMS\Install\Updates\RichTextFieldsUpdate::findRteFieldInFlexForm() must be of the type array, string given, called in master/typo3/sysext/install/Classes/Updates/RichTextFieldsUpdate.php on line 132 -
Oliver Hader uploaded patch set 14 05/03/16, 09:41
-
Oliver Hader commented on patch set 14 CR -1 05/03/16, 11:54
Still some flaw if record does not have type set n ctrl section -
Oliver Hader commented on patch set 14 V -1 05/03/16, 12:21
RichTextFieldsUpdate.php:107This needs to more flexible see TYPO3\CMS\Backend\Form\FormDataProvider\DatabaseRecordTypeValueRichTextFieldsUpdate.php:122This does not work if a table does not have ctrl/type set -
Christian Kuhn commented on patch set 14 CR -1 05/03/16, 12:21
RichTextFieldsUpdate.php:111this can easily run into memory limit issues for big tables.RichTextFieldsUpdate.php:122there is no type definition for records at all. for instance with tt_content, there are mulitple records with different types and only those that have an rte for the specific type should be migrated. For details to determine types, see DatabaseRecordTypeValue class from formEngine -
Christian Kuhn commented on patch set 14 05/03/16, 12:26
Current status: the patch is not ready and has loose ends. Benni says the parsing in RTE can deal with both <p> and without <p>, so this patch is not a must have, still we should get it done for 8.2. furthermore, the solution should be abstracted a bit better, since we need the find-rte-field-by-type-and-foo logic later for the link-syntax-upgrade wizards again. decision: no merge 8.1, but further work for 8.2 -
Christian Kuhn uploaded patch set 15 01/10/17, 13:23
-
Christian Kuhn commented on patch set 15 CR -2 01/10/17, 13:24
rebased. working on it. -
TYPO3com voted on patch set 15 V -1 01/10/17, 13:29 Completed build in 05m 19s on Tue, 10 Jan, 02:29 PM Test Summary: 54993 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6393
-
Christian Kuhn commented on patch set 15 CR -1 01/10/17, 16:13
will do a different one in a related area, first. -
Christian Kuhn commented on patch set 15 10/20/17, 11:46
this has been obsoleted meanwhile. abandoned. -
Christian Kuhn abandoned the change 10/20/17, 11:46