46702[TASK] Move moduleLabels to ModuleLoader
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Anja Leichsenring +1
- Nicole Hummel +1
-
Verified V +2
- Andreas Wolf +2
- Anja Leichsenring +1
- Nicole Hummel +1
Issues 1
Files 11
- typo3/sysext/about/Classes/Controller/ModulesController.php+13 −12
- typo3/sysext/about/Resources/Private/Templates/Modules/Index.html+20 −14
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php1+16 −19
- typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php+15 −11
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+13 −11
- typo3/sysext/backend/Classes/Module/ModuleLoader.php5+71 −17
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+5 −9
- typo3/sysext/backend/Tests/Unit/Module/ModuleLoaderTest.php2new+187 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+0 −10
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-72340-MovedModuleLabelsFromLanguageServiceToModuleLoader.rstnew+29 −0
- typo3/sysext/lang/Classes/LanguageService.php2+3 −0
Review log 32
Show 7 earlier messages
-
Benni Mack uploaded patch set 1 02/16/16, 10:56
-
Benni Mack wrote 02/16/16, 11:00
Patch set 2: Published edit on patch set 1. -
Mathias Schreiber wrote 02/16/16, 11:04
Patch set 3: Published edit on patch set 2. -
Wouter Wolters commented on patch set 3 CR +1 02/16/16, 22:58
Also checked TER for moduleLabels and although we have a few hits the extensions all look OLD -
Christian Kuhn commented on patch set 3 CR -1 02/19/16, 17:09
LanguageService.php:61this is breaking, isn't it? with applied patch, this property is now always empty and it even doesn't throw a deprecation msg. shouldn't we better add a magic __get() to track acces to this property, throw deprecation and then return the former values? -
Benni Mack commented on patch set 3 02/23/16, 06:35
yes. it's empty. There is no TER extension using LANG->moduleLabels compatible with v7 actually. (most of them are old skins from 4.1 times). So, we either remove the property completely (and mark the change as breaking) or always fill it as well (as before) and mark the access with a deprecation log with a magic getter method. -
Benni Mack commented on patch set 3 02/27/16, 20:21
OK. I don't consider this relevant for marking it breaking, after thinking about it again. It is still possible to access moduleLabels() if one uses the deprecated method in his own e.g. backend bootstrap process, thus throwing deprecations and filling the array, but it isn't evaluated from the core anymore.
-
Benni Mack uploaded patch set 4 03/04/16, 09:56
-
Wouter Wolters voted on patch set 4 CR +1 03/04/16, 10:30
-
Anja Leichsenring wrote 03/04/16, 10:41
Patch set 5: Commit message was updated. -
Anja Leichsenring voted on patch set 5 CR +1 V +1 03/04/16, 10:47
-
Christian Kuhn commented on patch set 5 03/04/16, 11:05
reviewing -
Nicole Hummel commented on patch set 5 CR -1 03/04/16, 11:15
ModuleLoader.php:400You test for isset() but using the key anyway?! Makes no sense to me -
Christian Kuhn commented on patch set 5 CR -1 03/04/16, 11:18
ModuleLoader.php:369i think it would be useful to add unit tests to this method in combination with the "getter" method below to show which exact inputs this method can handle.ModuleLoader.php:400Replytrue. stumbled upon that, too. -
Christian Kuhn commented on patch set 5 V -1 03/04/16, 11:25
-1 on testing: M=help_AboutAboutmodules #1351584844: An argument "key" or "id" has to be provided (More information) TYPO3Fluid\Fluid\Core\Exception thrown in file /var/www/t3master/cms-t3master/typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php in line 125. -
Nicole Hummel commented on patch set 5 03/04/16, 11:26
ModuleLoader.php:369not psr-2 compatibleModuleLoader.php:410not psr-2 compatible -
Nicole Hummel commented on patch set 5 03/04/16, 11:29
@christian: is there any third party extension installed for you? don't get any error in the module -
Benni Mack uploaded patch set 6 03/04/16, 17:46
-
Benni Mack uploaded patch set 7 03/04/16, 17:50
-
Nicole Hummel commented on patch set 7 03/04/16, 21:09
ModuleLoaderTest.php:175I would move this to setUp() IHMO globals are backup and restored automatically. no need to care about that on your own.ModuleLoaderTest.php:179I would assert expectation and function call "on the fly". no need for an extra variable here. -
Mathias Schreiber commented on patch set 7 CR -2 03/05/16, 10:10
fixing... -
Mathias Schreiber uploaded patch set 8 03/05/16, 11:35
-
Mathias Schreiber voted on patch set 8 CR +1 V +1 03/05/16, 11:41
-
Nicole Hummel commented on patch set 8 CR -1 03/05/16, 12:38
Will push an update -
Nicole Hummel uploaded patch set 9 03/05/16, 12:59
-
Nicole Hummel voted on patch set 9 CR +1 V +1 03/05/16, 12:59
-
Anja Leichsenring voted on patch set 9 CR +1 V +1 03/05/16, 13:07
-
Andreas Wolf voted on patch set 9 CR +2 V +2 03/05/16, 13:08
-
Gerrit merged patch set 9 03/05/16, 13:08
-
Frank Nägler commented on patch set 10 03/25/16, 10:49
LanguageService.php:62post -1, this property is still in use by SetupModuleController::renderStartModuleSelect(). currently the dropdown field is broken. It looks like this change is not a deprecation but a breaking change. -
Frank Nägler commented on patch set 10 03/25/16, 11:36
followup / bugfix: https://review.typo3.org/#/c/47392/ -
Nicole Hummel commented on patch set 10 10/07/16, 14:01
ShortcutToolbarItem.php:290Due to the design of the function checkMod the result is always an array with at least two properties. So this condition is superfluous.