46707[TASK] Disallow Composer installation with PHP 7.x
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Daniel Goerz +1
- Wouter Wolters +1
- Frank Nägler +1
- Andreas Kienast +1
- Nicole Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Daniel Goerz +1
Issues 1
Files 1
Review log 19
-
Mathias Brodala uploaded patch set 1 02/16/16, 11:33
-
Stephan Großberndt commented on patch set 1 02/16/16, 14:35
why is it not compatible? -
Mathias Brodala commented on patch set 1 02/16/16, 14:38
See the various changes which where necessary in 7.6 to make that one compatible to PHP 7. -
Mathias Brodala commented on patch set 1 02/16/16, 14:39
See especially https://forge.typo3.org/issues/65314 -
Stephan Großberndt commented on patch set 1 02/16/16, 15:04
the sorting issues have been solved in PHP7 upstream or just created problems with tests, not with the code itself. The crashes have been solved in PHP7 upstream. "should be compatible with" are warnings - with a "should", not a "must" and can be disabled by "error_reporting(E_ALL ^ E_STRICT);"? So the only real issue I see is https://forge.typo3.org/issues/67362 which is when using DBAL. As far as this is not enforced in PHP code I am fine with changing the composer-requirement - while I do think it is really necessary to do so. -
Christian Kuhn commented on patch set 1 CR +1 02/16/16, 21:23
Stephan, at the moment 6.2 does not support php 7 and there are know issues. we had quite some hard time to add php 5.6 to the list of supported php versions, it took us more than half a year to fix the last issue and to not break php 5.3 and 5.4. if you think php 7 can be done in 6.2, please start adding patches towards this, those need to be thoroughly tested then. also, 6.2 is in a 'security only' branch already and it may be hard to fight such patches through. if its working, we may finally release php 7 restricion on 6.2 again. until then, a clear 'php 7 does not work well' is imho the right way to go. -
Nicole Hummel commented on patch set 1 CR -1 02/17/16, 09:49
composer.lock change is missing -
Wouter Wolters commented on patch set 1 CR +1 02/17/16, 09:56
We do not have a composer.lock in 6.2 branch -
Mathias Brodala commented on patch set 1 02/17/16, 10:01
> composer.lock change is missing As Wouter said; it's still in the .gitignore for 6.2. -
Nicole Hummel commented on patch set 1 CR +1 02/17/16, 10:02
Ah, missed that. Thanks -
Andreas Kienast voted on patch set 1 CR +1 02/17/16, 15:39
-
Daniel Goerz voted on patch set 1 CR +1 V +1 02/19/16, 23:10
-
Christian Kuhn voted on patch set 1 V +1 02/20/16, 11:45
-
Frank Nägler voted on patch set 1 CR +1 02/20/16, 11:45
-
Frank Nägler commented on patch set 1 CR -1 02/20/16, 11:46
composer.lock missing!? -
Andreas Kienast commented on patch set 1 02/20/16, 11:47
6.2 has no composer.lock -
Frank Nägler commented on patch set 1 CR +1 02/20/16, 11:47
missed, the comment above... -
Christian Kuhn voted on patch set 1 CR +2 V +2 02/20/16, 11:49
-
Gerrit merged patch set 1 02/20/16, 11:49