Review main Merged

46708[TASK] Discourage usage of $LANG->csConvObj and parserFactory

Benni Mack CR +2 V +2 Normal +63 −29 updated 02/17/16, 04:50

Commit message

The csConvObj is decoupled from LanguageService and
not used directly anymore.

Any calls directly to the property csConvObj should be avoided
as was marked as deprecated.

Same goes with the property "parserFactory" of the
LanguageService class. The parser factory is not called
from the language object anymore and the property can be
removed.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 9

  1. Benni Mack uploaded patch set 1 02/16/16, 11:45

  2. Georg Ringer uploaded patch set 2 02/16/16, 12:52

  3. Georg Ringer voted on patch set 2 CR +1 V +1 02/16/16, 12:53

  4. Tymoteusz Motylewski voted on patch set 2 CR +1 02/16/16, 16:53

  5. Benni Mack uploaded patch set 3 02/16/16, 20:12

  6. Wouter Wolters wrote 02/16/16, 22:45

    Patch set 4: Commit message was updated.
  7. Wouter Wolters voted on patch set 4 CR +1 V +1 02/16/16, 22:45

  8. Georg Ringer voted on patch set 4 CR +2 V +2 02/17/16, 04:50

  9. Gerrit merged patch set 4 02/17/16, 04:50