Review main Merged

46712[BUGFIX] Allow OnlineMedia Renderers to override via Fluid

Benni Mack CR +2 V +2 Easy +45 −2 updated 02/29/16, 20:21

Commit message

When using the Online Media (Youtube / Vimeo) then the autoplay
option is always taken from the FileReference, overriding
the option that might be set via Fluid.

A check if the option hasn't been set yet makes the overriding
order clearer.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Gorges +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Gorges +1

Issues 1

Files 4

Review log 12

  1. Benni Mack uploaded patch set 1 02/16/16, 13:36

  2. Daniel Gorges voted on patch set 1 CR +1 V +1 02/16/16, 13:36

  3. Wouter Wolters voted on patch set 1 CR +1 02/16/16, 22:46

  4. Frans Saris voted on patch set 1 CR +1 02/17/16, 12:10

  5. Andreas Kienast voted on patch set 1 CR +1 02/17/16, 13:16

  6. Christian Kuhn uploaded patch set 2 02/19/16, 16:50

  7. Christian Kuhn commented on patch set 2 CR -1 02/19/16, 16:58

    both classes have unit tests already. would be great to cover this case with tests.
  8. Benni Mack uploaded patch set 3 02/27/16, 19:55

  9. Daniel Gorges voted on patch set 3 CR +1 V +1 02/29/16, 10:19

  10. Wouter Wolters voted on patch set 3 CR +2 V +2 02/29/16, 20:20

  11. Gerrit merged patch set 3 02/29/16, 20:20

  12. Wouter Wolters commented on patch set 4 02/29/16, 20:21

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 952689788588033de6c0af088a4cacae9e59c697