Review main Merged

46729[BUGFIX] Use proper URL for file list of returnUrl in file_upload

Benni Mack CR +2 V +2 Easy +3 −3 updated 02/24/16, 11:15

Commit message

When the file upload controller is called (which is almost
impossible to call these days) and no return URL is given
(which is again almost impossible), then the URL is invalid.

The patch uses the proper getModuleUrl() call which is
sufficient.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Daniel Goerz +1
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 11

  1. Benni Mack uploaded patch set 1 02/16/16, 19:59

  2. Wouter Wolters wrote 02/16/16, 20:58

    Patch set 2: Commit message was updated.
  3. Wouter Wolters voted on patch set 2 CR +1 V +1 02/16/16, 20:59

  4. Christian Kuhn commented on patch set 2 02/19/16, 17:11

    how to test?
  5. Daniel Goerz voted on patch set 2 CR +1 02/19/16, 17:31

  6. Frank Nägler commented on patch set 2 02/22/16, 15:58

    how to test?
  7. Daniel Goerz commented on patch set 2 02/22/16, 16:01

    @Frank from the commit message I assume it is almost impossible to test this ;)
  8. Benni Mack commented on patch set 2 02/23/16, 05:55

    Nasty to test: - Go to file module. Instead of clicking the link in the docheader to show the file upload dialog, get the source code and the link to the actualy file upload controller page. - Open that page directly now (e.g. in a new browser tab) - Change the URL of that module to remove the redirectUrl parameter - Check the HTML source code output and you'll see the broken URL with twice /typo3/. - After applying the patch, the URL looks quite "normal". You can of course test it this way as well by uploading a file (and you'll get a 404 without the patch)
  9. Frank Nägler voted on patch set 2 CR +2 V +2 02/24/16, 11:15

  10. Gerrit merged patch set 2 02/24/16, 11:15

  11. Frank Nägler commented on patch set 3 02/24/16, 11:15

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 14d64ed184eed9059454b4a5ed41ffb6832bf966