Review main Merged Breaking

46740[!!!][TASK] Deprecate various GeneralUtility methods

Benni Mack CR +2 V +2 Normal +146 −56 updated 03/03/16, 20:23

Commit message

GeneralUtility::flushOutputBuffers()
GeneralUtility::xmlGetHeaderAttribs()
GeneralUtility::imageMagickCommand()

Parameters 2+3 of
GeneralUtility::getFileAbsFileName()

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 15

Review log 20

  1. Benni Mack uploaded patch set 1 02/17/16, 08:11

  2. Benni Mack uploaded patch set 2 02/17/16, 08:50

  3. Wouter Wolters voted on patch set 2 CR +1 02/17/16, 09:05

  4. Frank Nägler commented on patch set 2 CR -1 02/19/16, 15:36

    lolli will push an update ;)
  5. Christian Kuhn uploaded patch set 3 02/19/16, 15:43

  6. Christian Kuhn commented on patch set 3 CR -1 02/19/16, 15:44

    GeneralUtility.php:3489

    imho, this is breaking. but we should write some unit tests for this method anyway to see the details.
  7. Christian Kuhn commented on patch set 3 02/19/16, 15:50

    frank will add tests for the method in question.
  8. Christian Kuhn commented on patch set 3 CR 0 V -1 02/19/16, 16:35

    5 test fails after merge of https://review.typo3.org/#/c/46783/
  9. Frank Nägler commented on patch set 3 V -1 02/19/16, 16:35

    good patch, but unit tests broken ;)
  10. Benni Mack uploaded patch set 4 02/24/16, 06:06

  11. Andreas Kienast voted on patch set 4 CR +1 V +1 02/24/16, 08:25

  12. Georg Ringer commented on patch set 4 02/24/16, 08:26

    Breaking-73516-GeneralUtilitygetFileAbsFileNameAllowsForTypo3MaindirSpecificPaths.rst:15

    does this need to be escaped?
  13. Frank Nägler commented on patch set 4 CR -1 02/24/16, 08:49

    soft -1 please see the inline comment, specially for the unit tests

    Breaking-73516-GeneralUtilitygetFileAbsFileNameAllowsForTypo3MaindirSpecificPaths.rst:15 Reply

    don't get it!? What should be escaped?

    Breaking-73516-GeneralUtilitygetFileAbsFileNameAllowsForTypo3MaindirSpecificPaths.rst:27

    can be removed

    Breaking-73516-GeneralUtilitygetFileAbsFileNameAllowsForTypo3MaindirSpecificPaths.rst:27

    within typo3/sysext OR typo3conf/ext OR better: within extension folders?

    GeneralUtilityTest.php:4194

    we should add Tests for EXT: prefix with sysext and extension from typo3conf. Not sure how we could test it with extensions from typo3conf/ext/ but imho this cases missing here.
  14. Benni Mack uploaded patch set 5 02/27/16, 20:17

  15. Wouter Wolters commented on patch set 5 CR -1 02/29/16, 20:53

    PackageManager needs to be reset within the test
  16. Benni Mack uploaded patch set 6 03/03/16, 16:32

  17. Wouter Wolters voted on patch set 6 CR +1 V +1 03/03/16, 18:24

  18. Christian Kuhn commented on patch set 6 03/03/16, 20:14

    DocumentTemplate.php:1254

    ok.
  19. Christian Kuhn voted on patch set 6 CR +2 V +2 03/03/16, 20:21

  20. Gerrit merged patch set 6 03/03/16, 20:23