46740[!!!][TASK] Deprecate various GeneralUtility methods
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
Issues 1
Files 15
- typo3/sysext/backend/Classes/Console/CliRequestHandler.php+3 −4
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php1+2 −2
- typo3/sysext/core/Classes/Console/CommandRequestHandler.php+1 −1
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+5 −5
- typo3/sysext/core/Classes/Page/PageRenderer.php+1 −1
- typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php+1 −1
- typo3/sysext/core/Classes/Resource/Processing/LocalPreviewHelper.php+1 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php1+20 −11
- typo3/sysext/core/Documentation/Changelog/master/Breaking-73516-GeneralUtilitygetFileAbsFileNameAllowsForTypo3MaindirSpecificPaths.rst4new+29 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-73516-VariousGeneralUtilityMethods.rstnew+37 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php1+40 −20
- typo3/sysext/cshmanual/Classes/Domain/Repository/TableManualRepository.php+2 −2
- typo3/sysext/extensionmanager/Classes/Utility/ConfigurationUtility.php+1 −2
- typo3/sysext/extensionmanager/Classes/Utility/UpdateScriptUtility.php+1 −4
Review log 20
-
Benni Mack uploaded patch set 1 02/17/16, 08:11
-
Benni Mack uploaded patch set 2 02/17/16, 08:50
-
Wouter Wolters voted on patch set 2 CR +1 02/17/16, 09:05
-
Frank Nägler commented on patch set 2 CR -1 02/19/16, 15:36
lolli will push an update ;) -
Christian Kuhn uploaded patch set 3 02/19/16, 15:43
-
Christian Kuhn commented on patch set 3 CR -1 02/19/16, 15:44
GeneralUtility.php:3489imho, this is breaking. but we should write some unit tests for this method anyway to see the details. -
Christian Kuhn commented on patch set 3 02/19/16, 15:50
frank will add tests for the method in question. -
Christian Kuhn commented on patch set 3 CR 0 V -1 02/19/16, 16:35
5 test fails after merge of https://review.typo3.org/#/c/46783/ -
Frank Nägler commented on patch set 3 V -1 02/19/16, 16:35
good patch, but unit tests broken ;) -
Benni Mack uploaded patch set 4 02/24/16, 06:06
-
Andreas Kienast voted on patch set 4 CR +1 V +1 02/24/16, 08:25
-
Georg Ringer commented on patch set 4 02/24/16, 08:26
Breaking-73516-GeneralUtilitygetFileAbsFileNameAllowsForTypo3MaindirSpecificPaths.rst:15does this need to be escaped? -
Frank Nägler commented on patch set 4 CR -1 02/24/16, 08:49
soft -1 please see the inline comment, specially for the unit testsBreaking-73516-GeneralUtilitygetFileAbsFileNameAllowsForTypo3MaindirSpecificPaths.rst:15Replydon't get it!? What should be escaped?Breaking-73516-GeneralUtilitygetFileAbsFileNameAllowsForTypo3MaindirSpecificPaths.rst:27can be removedBreaking-73516-GeneralUtilitygetFileAbsFileNameAllowsForTypo3MaindirSpecificPaths.rst:27within typo3/sysext OR typo3conf/ext OR better: within extension folders?GeneralUtilityTest.php:4194we should add Tests for EXT: prefix with sysext and extension from typo3conf. Not sure how we could test it with extensions from typo3conf/ext/ but imho this cases missing here. -
Benni Mack uploaded patch set 5 02/27/16, 20:17
-
Wouter Wolters commented on patch set 5 CR -1 02/29/16, 20:53
PackageManager needs to be reset within the test -
Benni Mack uploaded patch set 6 03/03/16, 16:32
-
Wouter Wolters voted on patch set 6 CR +1 V +1 03/03/16, 18:24
-
Christian Kuhn commented on patch set 6 03/03/16, 20:14
DocumentTemplate.php:1254ok. -
Christian Kuhn voted on patch set 6 CR +2 V +2 03/03/16, 20:21
-
Gerrit merged patch set 6 03/03/16, 20:23