Review main Abandoned

46758[BUGFIX] Use HttpRequest inside getUrl to have correct HTTP settings

Albrecht Köhnlein CR 0 V 0 Easy +9 −9 updated 12/07/16, 14:53

Commit message

Replaced "file_get_content()" inside GeneralUtility::getUrl by
TYPO3\CMS\Core\Http\HttpRequest. It's only a proposal and not a finished
solution. The $includeHeader part with fsockopen is not done at all. And
I don't know how local files are handled inside getUrl(), so I don't know
if this could be a conflict. But it works for my case in Extension Manager
behind a proxy and without CURL installed on the server.
And I only tested it on TYPO3 6.2, but I think it's the same here in the
master. Even if the code differs in TYPO3 7. But I'm sure there would be
a way to bring it to old LTS in Git.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 3

  1. Albrecht Köhnlein uploaded patch set 1 02/18/16, 15:29

  2. Wouter Wolters commented on patch set 1 CR -1 06/07/16, 21:02

    In master we have Guzzle implemented now. Is this still a problem there?
  3. Wouter Wolters abandoned the change 12/07/16, 14:53

    No response for a couple of months now and master has guzzle for some time already in place. If this is still an issue in 7 please push a new patch to the 7.6 branch.