Review main Merged

46773[BUGFIX] Make SingleTasks toggleable from scheduler list view

Andreas Kienast CR +2 V +2 Easy +34 −12 updated 03/11/16, 09:08

Commit message

The toggle button for tasks does not work for single tasks. This patch
enables the functionality and registers a single task for execution on
next scheduler run when enabled.

Additionally class constants are introduced for the two available types.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Daniel Goerz +1
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Frank Nägler +2
    • Daniel Goerz +1
    • Riccardo De Contardi +1
    • Andreas Kienast +1

Issues 1

Files 2

Review log 19

  1. Andreas Kienast uploaded patch set 1 02/19/16, 11:19

  2. Andreas Kienast uploaded patch set 2 02/19/16, 11:20

  3. Wouter Wolters commented on patch set 2 02/19/16, 11:41

    SchedulerModuleController.php:1027

    ->render()
  4. Andreas Kienast uploaded patch set 3 02/19/16, 12:20

  5. Wouter Wolters voted on patch set 3 CR +1 V +1 02/19/16, 12:22

  6. Christian Kuhn commented on patch set 3 CR -1 02/19/16, 15:06

    fank and me don't understand this: a 'single' task means, the task sets itself to disabled after its execution. we do have tasks in our projects that are run only once in a while. it would be useful to set them to 'enabled' in the list, so it will be run (once) at next scheduler run. we think it would be better to fix the issue and allow enabling of tasks in the list interface and not only in the detail view of a task.
  7. Christian Kuhn commented on patch set 3 02/19/16, 15:07

    "Frank and I" ;)
  8. Benni Mack commented on patch set 3 03/03/16, 17:41

    agreed with Christian. Andy, could you update that patch?
  9. Andreas Kienast commented on patch set 3 03/03/16, 18:12

    Sorry, unfortunately not within a decent timeframe.
  10. Daniel Goerz uploaded patch set 4 03/06/16, 14:01

  11. Daniel Goerz wrote 03/06/16, 14:05

    Patch set 5: Commit message was updated.
  12. Daniel Goerz wrote 03/06/16, 14:10

    Patch set 6: Commit message was updated.
  13. Wouter Wolters voted on patch set 6 CR +1 03/06/16, 15:54

  14. Daniel Goerz voted on patch set 6 CR +1 V +1 03/07/16, 21:17

  15. Riccardo De Contardi commented on patch set 6 V +1 03/08/16, 17:00

    before the patch: the enable/disable switch works only in one way: you can disable the task but not enable it again. after: you can enable/disable it
  16. Andreas Kienast voted on patch set 6 CR +1 V +1 03/10/16, 14:43

  17. Frank Nägler voted on patch set 6 CR +2 V +2 03/11/16, 09:08

  18. Gerrit merged patch set 6 03/11/16, 09:08

  19. Frank Nägler commented on patch set 7 03/11/16, 09:08

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 2c1ee837edabc3359096a90d2f7b43cff8b6ffef