Review main Merged

46787[BUGFIX] Solves PHP warning in FileAllowedTypesValidator

Wouter Wolters CR +2 V +2 Normal +63 −27 updated 03/04/16, 17:43

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Jan Helke +1
    • Frank Nägler +1
    • Ralf Zimmermann +1
    • Nicole Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Jan Helke +1
    • Ralf Zimmermann +1
    • Nicole Hummel +1

Issues 2

Files 2

Review log 28

Show 3 earlier messages
  1. Wouter Wolters commented on patch set 1 02/19/16, 19:36

    Cherry Picked from branch TYPO3_7-6.
  2. Georg Ringer voted on patch set 1 CR +1 V +1 02/23/16, 05:01

  3. Christian Kuhn commented on patch set 1 02/24/16, 13:27

    maybe one of the ext:form people could have a look at this one?
  1. Christian Kuhn commented on patch set 1 02/24/16, 13:29

    pinged them in #ext-form
  2. Frank Nägler commented on patch set 1 02/29/16, 09:13

    FileAllowedTypesValidator.php:72

    here a cast to array is used, but above in isValid this setting is used as string with strtolower... what type it is here!? The type mixing is a bad style and will make problems more and more...
  3. Ralf Zimmermann uploaded patch set 2 03/03/16, 17:49

  4. Wouter Wolters voted on patch set 2 CR +1 03/03/16, 17:58

  5. Florian Mast voted on patch set 1 V +1 03/03/16, 19:15

  6. Florian Mast voted on patch set 2 CR +1 V +1 03/03/16, 19:27

  7. Björn Jacob voted on patch set 2 CR +1 V +1 03/03/16, 19:44

  8. Florian Mast commented on patch set 2 CR -1 03/03/16, 20:34

    function isValid($value) should not have a default value like $value=array()

    FileAllowedTypesValidator.php:46

    default value=array() is not a good idea: 1. isValid should probably called with an mandatory argument $value 2. if isValid() is called without argument, this will lead to an exception if $value["type"] accessed on an empty array $value.
  9. Florian Mast uploaded patch set 3 03/04/16, 10:54

  10. Florian Mast uploaded patch set 4 03/04/16, 11:45

  11. Nicole Hummel commented on patch set 4 CR -1 03/04/16, 14:02

    Will push an update
  12. Nicole Hummel uploaded patch set 5 03/04/16, 14:18

  13. Nicole Hummel voted on patch set 5 CR +1 V +1 03/04/16, 14:19

  14. Frank Nägler commented on patch set 5 CR -1 03/04/16, 15:32

    FileAllowedTypesValidator.php:47

    can we add a type hint here?

    FileAllowedTypesValidatorTest.php:15

    wrong indentation
  15. Nicole Hummel commented on patch set 5 03/04/16, 16:05

    FileAllowedTypesValidator.php:47 Reply

    TBH: not sure if we can

    FileAllowedTypesValidatorTest.php:15 Reply

    Done
  16. Nicole Hummel uploaded patch set 6 03/04/16, 16:05

  17. Nicole Hummel voted on patch set 6 CR +1 V +1 03/04/16, 16:06

  18. Ralf Zimmermann commented on patch set 6 03/04/16, 16:09

    Imho a type hint is not possible because of the \TYPO3\CMS\Extbase\Validation\Validator\AbstractValidator implementation.
  19. Christian Kuhn commented on patch set 6 03/04/16, 16:13

    nice. thanks! let's gather some further votes and get it done.
  20. Frank Nägler commented on patch set 6 CR +1 03/04/16, 16:13

    Yes Ralf, good catch, thx
  21. Ralf Zimmermann voted on patch set 6 CR +1 V +1 03/04/16, 17:05

  22. Jan Helke voted on patch set 6 CR +1 03/04/16, 17:24

  23. Jan Helke voted on patch set 6 V +1 03/04/16, 17:27

  24. Wouter Wolters voted on patch set 6 CR +2 V +2 03/04/16, 17:42

  25. Gerrit merged patch set 6 03/04/16, 17:43