46787[BUGFIX] Solves PHP warning in FileAllowedTypesValidator
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Jan Helke +1
- Frank Nägler +1
- Ralf Zimmermann +1
- Nicole Hummel +1
-
Verified V +2
- Wouter Wolters +2
- Jan Helke +1
- Ralf Zimmermann +1
- Nicole Hummel +1
Issues 2
Files 2
Review log 28
Show 3 earlier messages
-
Christian Kuhn commented on patch set 1 02/24/16, 13:29
pinged them in #ext-form -
Frank Nägler commented on patch set 1 02/29/16, 09:13
FileAllowedTypesValidator.php:72here a cast to array is used, but above in isValid this setting is used as string with strtolower... what type it is here!? The type mixing is a bad style and will make problems more and more... -
Ralf Zimmermann uploaded patch set 2 03/03/16, 17:49
-
Wouter Wolters voted on patch set 2 CR +1 03/03/16, 17:58
-
Florian Mast voted on patch set 1 V +1 03/03/16, 19:15
-
Florian Mast voted on patch set 2 CR +1 V +1 03/03/16, 19:27
-
Björn Jacob voted on patch set 2 CR +1 V +1 03/03/16, 19:44
-
Florian Mast commented on patch set 2 CR -1 03/03/16, 20:34
function isValid($value) should not have a default value like $value=array()FileAllowedTypesValidator.php:46default value=array() is not a good idea: 1. isValid should probably called with an mandatory argument $value 2. if isValid() is called without argument, this will lead to an exception if $value["type"] accessed on an empty array $value. -
Florian Mast uploaded patch set 3 03/04/16, 10:54
-
Florian Mast uploaded patch set 4 03/04/16, 11:45
-
Nicole Hummel commented on patch set 4 CR -1 03/04/16, 14:02
Will push an update -
Nicole Hummel uploaded patch set 5 03/04/16, 14:18
-
Nicole Hummel voted on patch set 5 CR +1 V +1 03/04/16, 14:19
-
Frank Nägler commented on patch set 5 CR -1 03/04/16, 15:32
FileAllowedTypesValidator.php:47can we add a type hint here?FileAllowedTypesValidatorTest.php:15wrong indentation -
Nicole Hummel commented on patch set 5 03/04/16, 16:05
FileAllowedTypesValidator.php:47ReplyTBH: not sure if we canFileAllowedTypesValidatorTest.php:15ReplyDone -
Nicole Hummel uploaded patch set 6 03/04/16, 16:05
-
Nicole Hummel voted on patch set 6 CR +1 V +1 03/04/16, 16:06
-
Ralf Zimmermann commented on patch set 6 03/04/16, 16:09
Imho a type hint is not possible because of the \TYPO3\CMS\Extbase\Validation\Validator\AbstractValidator implementation. -
Christian Kuhn commented on patch set 6 03/04/16, 16:13
nice. thanks! let's gather some further votes and get it done. -
Frank Nägler commented on patch set 6 CR +1 03/04/16, 16:13
Yes Ralf, good catch, thx -
Ralf Zimmermann voted on patch set 6 CR +1 V +1 03/04/16, 17:05
-
Jan Helke voted on patch set 6 CR +1 03/04/16, 17:24
-
Jan Helke voted on patch set 6 V +1 03/04/16, 17:27
-
Wouter Wolters voted on patch set 6 CR +2 V +2 03/04/16, 17:42
-
Gerrit merged patch set 6 03/04/16, 17:43