Review main Merged

46788[BUGFIX] Fix minor flaws in wizard component

Andreas Kienast CR +2 V +2 Normal +80 −62 updated 02/22/16, 13:39

Commit message

After closing the wizard the internal settings object stays an object and
is not converted to an array.

Wizard.getComponent() now generates the markup if Wizard.show()
was not called before. Also, the method now returns only the generated
markup and not the (missing) modal window.

Also, the events of the wizard component are now used and not the
bootstrap modal events.

The documentation is adjusted a bit and Localization.js is fixed.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Daniel Goerz +1
  • Verified V +2
    • Frank Nägler +2
    • Daniel Goerz +1

Issues 1

Files 3

Review log 12

  1. Andreas Kienast uploaded patch set 1 02/19/16, 20:48

  2. Daniel Goerz voted on patch set 1 CR +1 02/19/16, 23:06

  3. Andreas Kienast uploaded patch set 2 02/22/16, 10:04

  4. Andreas Kienast wrote 02/22/16, 10:05

    Patch set 3: Published edit on patch set 2.
  5. Andreas Kienast uploaded patch set 4 02/22/16, 10:17

  6. Andreas Kienast voted on patch set 4 V -1 02/22/16, 10:29

  7. Andreas Kienast wrote 02/22/16, 10:34

    Patch set 5: Published edit on patch set 4.
  8. Frank Nägler uploaded patch set 6 02/22/16, 13:02

  9. Frank Nägler voted on patch set 6 CR +1 V +1 02/22/16, 13:02

  10. Daniel Goerz voted on patch set 6 CR +1 V +1 02/22/16, 13:22

  11. Frank Nägler voted on patch set 6 CR +2 V +2 02/22/16, 13:39

  12. Gerrit merged patch set 6 02/22/16, 13:39