Review main Merged

46808[TASK] Optimize IconRegistry and IconFactory

Frank Nägler CR +2 V +2 Normal +43 −48 updated 02/24/16, 04:58

Commit message

Add a runtime cache for icons and remove the calls to getDeprecationSettings.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 10

  1. Frank Nägler uploaded patch set 1 02/22/16, 12:27

  2. Michiel Roos voted on patch set 1 CR +1 V +1 02/22/16, 18:25

  3. Frank Nägler uploaded patch set 2 02/22/16, 18:50

  4. Stephan Großberndt commented on patch set 2 02/22/16, 20:32

    Shouldn't the function get a call to logDeprecatedFunction() or is this on purpose due to the number of calls?
  5. Frank Nägler commented on patch set 2 CR -1 02/23/16, 21:08

    @Stephan: sure, my mistake -.- Will push an update soon
  6. Frank Nägler uploaded patch set 3 02/23/16, 21:10

  7. Wouter Wolters wrote 02/23/16, 21:12

    Patch set 4: Published edit on patch set 3.
  8. Wouter Wolters voted on patch set 4 CR +1 V +1 02/23/16, 21:16

  9. Georg Ringer voted on patch set 4 CR +2 V +2 02/24/16, 04:58

  10. Gerrit merged patch set 4 02/24/16, 04:58