Review main Merged Breaking

46812[!!!][TASK] Remove possibility for index.php?32

Benni Mack CR +2 V +2 Easy +31 −19 updated 02/24/16, 08:22

Commit message

A Frontend request could previously be called with
index.php?id=[id] or just index.php?[id].

The support for calling pages through the syntax of index.php?[id]
was removed, along with the method $TSFE->setIDfromArgV.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • Andreas Kienast +1

Issues 1

Files 2

Review log 8

  1. Benni Mack uploaded patch set 1 02/22/16, 17:08

  2. Georg Ringer voted on patch set 1 CR +1 V +1 02/23/16, 04:54

  3. Wouter Wolters commented on patch set 1 02/23/16, 18:16

    this sentence is wrong IMO. This tells me that both options are removed, but we only remove index.php?[id]
  4. Benni Mack wrote 02/24/16, 05:51

    Patch set 2: Commit message was updated.
  5. Wouter Wolters voted on patch set 2 CR +1 02/24/16, 07:38

  6. Andreas Kienast voted on patch set 2 CR +1 V +1 02/24/16, 08:09

  7. Georg Ringer voted on patch set 2 CR +2 V +2 02/24/16, 08:22

  8. Gerrit merged patch set 2 02/24/16, 08:22