46821[!!!][TASK] Have ResourceCompressor calculate relative paths
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Mathias Schreiber +1
- Wouter Wolters +1
- Daniel Gorges +1
- Sebastian Fischer +1
-
Verified V +2
- Benni Mack +2
- Mathias Schreiber +1
- Daniel Gorges +1
Issues 1
Files 4
- typo3/sysext/core/Classes/Page/PageRenderer.php2+6 −14
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php1+12 −66
- typo3/sysext/core/Documentation/Changelog/master/Breaking-73611-RemovedResourceCompressorRelativePathMethods.rstnew+27 −0
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+0 −5
Review log 12
-
Benni Mack uploaded patch set 1 02/23/16, 06:53
-
Benni Mack commented on patch set 1 CR -1 02/23/16, 07:02
Breaking RST missing for the public methods that are removed. -
Andreas Kienast commented on patch set 1 02/23/16, 07:27
PageRenderer.php:2703else {return $filename} ? -
Benni Mack wrote 02/23/16, 08:16
Patch set 2: Published edit on patch set 1. -
Benni Mack uploaded patch set 3 02/27/16, 19:44
-
Sebastian Fischer voted on patch set 3 CR +1 03/01/16, 12:47
-
Mathias Schreiber voted on patch set 3 CR +1 V +1 03/01/16, 14:41
-
Wouter Wolters voted on patch set 3 CR +1 03/01/16, 17:56
-
Daniel Gorges voted on patch set 3 CR +1 V +1 03/02/16, 05:43
-
Benni Mack commented on patch set 3 CR +2 V +2 03/02/16, 05:47
PageRenderer.php:2703Replyso right, yes! -
Gerrit merged patch set 3 03/02/16, 05:48
-
Michiel Roos commented on patch set 4 03/02/16, 20:42
This breaks css file compression.ResourceCompressor.php:356Compressed stylesheets will no longer be created because: "/var/www/dev-master.local.typo3.org/typo3/sysext/t3skin/Resources/Public/Css/backend.css" is not equal to "/var/www/dev-master.local.typo3.org/typo3temp/assets/compressed/backend-38ec86af21587926c000b6e8facff914.css"