Review main Merged

46848[BUGFIX] Set correct variable type in Extension model

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 02/23/16, 20:51

Commit message

In the Extension model from the extension manager the variable type of
$dependencies is wrong. This should be
\TYPO3\CMS\Extensionmanager\Domain\Model\Dependency
instead of Tx_Extensionmanager_Utility_Dependency.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Daniel Goerz +1
    • Stephan Großberndt +1
    • Andreas Kienast +1
  • Verified V +2
    • Nicole Hummel +2
    • Daniel Goerz +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 8

  1. Wouter Wolters uploaded patch set 1 02/23/16, 18:22

  2. Wouter Wolters wrote 02/23/16, 18:24

    Patch set 2: Commit message was updated.
  3. Andreas Kienast voted on patch set 2 CR +1 V +1 02/23/16, 19:36

  4. Stephan Großberndt voted on patch set 2 CR +1 02/23/16, 19:39

  5. Daniel Goerz voted on patch set 2 CR +1 V +1 02/23/16, 20:50

  6. Nicole Hummel voted on patch set 2 CR +2 V +2 02/23/16, 20:51

  7. Gerrit merged patch set 2 02/23/16, 20:51

  8. Nicole Hummel commented on patch set 3 02/23/16, 20:51

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit b1fa4def5be2563db1c5a27a8cf6225d10e4d20b